emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <n.goaziou@gmail.com>
To: "T.F. Torrey" <tftorrey@tftorrey.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug: New HTML exporter incorrect attributes
Date: Sat, 23 Feb 2013 11:16:13 +0100	[thread overview]
Message-ID: <87fw0nibde.fsf@gmail.com> (raw)
In-Reply-To: <87621j9xgh.fsf@lapcat.tftorrey.com> (T. F. Torrey's message of "Sat, 23 Feb 2013 02:43:58 -0700")

tftorrey@tftorrey.com (T.F. Torrey) writes:

>> You don't assign attributes to an image in a paragraph, you assign
>> attributes to the paragraph itself.
>
> It would be nice if there actually was a way to assign an attribute to a
> paragraph, so that the ATTR_HTML: class="XXX" syntax would export as <p
> class="XXX">, but that is a different issue.

It would be ATTR_HTML: :class "XXX". I try to unify syntax for
attributes with syntax for Babel and AFAICT, `html' is the last back-end
to have key="value" syntax.

>> For the time being, Org syntax
>> doesn't allow to specify attributes per link object.
>
> I think what you are saying is that the current intended behavior is for
> whatever is specified by ATTR_HTML to apply to every image or link in
> the paragraph.

No. I am saying that ATTR_HTML behaviour in _undefined_ when a paragraph
contains more than one link, as it has always been.

If you carefully look at Org manual (in application with previous
exporter framework), in "Images in HTML export", you will notice that
HTML attributes only apply to a single link pointing to an image, not to
a paragraph containing many links.

>> As a consequence, attributes will be assigned to every link within the
>> paragraph.
>
> Is this behavior helpful to anyone in any practical circumstances?

I never said it was. It's not even a feature. I'm just explaining what
is happening.

> Moreover, this means that, not only does the new exporter fail where the
> old one succeeded,

I worked hard to make the new export framework compatible with defined
behaviour of previous exporter, not with handy undocumented side-effects
it may have.

> It seems to me that, whether the user is happy with the output or not,
> the HTML exporter ought to produce valid HTML.

I agree. But, in this case, you're using undefined Org syntax (which,
admittedly, used to "work" for you).

If there's a simple patch that mimics this for html back-end, I don't
mind applying it. But it still won't make up for a real solution.

Unless, that is, it is decided that this behaviour is an official
feature supported by Org, in which case, it should be added to the
manual.

> A more general workaround that would help everyone affected would be to
> temporarily modify ox-html.el so that attributes from ATTR_HTML only
> apply to the *first* item in the paragraph.  This would have the
> advantage of mimicking the behavior of the old exporter (thus not
> breaking existing content) and of keeping images for other export
> formats.  Of course, anyone relying on the ATTR_HTML to set attributes
> for every image and/or link in a paragraph would have to adopt a
> different workaround, but ... does anyone really do this?

It would solve your problem. But what if someone starts a paragraph with
a regular link and thereafter, add an image? ATTR_HTML attributes would
never reach it.

Again, there's no proper solution besides modifying link syntax.


Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2013-02-23 10:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-22 22:23 Bug: New HTML exporter incorrect attributes T.F. Torrey
2013-02-22 23:18 ` Nicolas Goaziou
2013-02-23  9:43   ` T.F. Torrey
2013-02-23 10:16     ` Nicolas Goaziou [this message]
2013-02-24 20:27       ` Samuel Wales
2013-02-25  8:23         ` Nicolas Goaziou
2013-02-25 10:55       ` T.F. Torrey
2013-02-25 13:49         ` Nicolas Goaziou
2013-02-25 13:57           ` Vincent Beffara
2013-02-25 14:03             ` Nicolas Goaziou
2013-02-25 20:51           ` T.F. Torrey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fw0nibde.fsf@gmail.com \
    --to=n.goaziou@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=tftorrey@tftorrey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).