emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Eric Schulte <schulte.eric@gmail.com>
To: Michael Brand <michael.ch.brand@gmail.com>
Cc: Org Mode <emacs-orgmode@gnu.org>, Eric Schulte <schulte.eric@gmail.com>
Subject: Re: link abbreviation with multiple params, e. g. for geo locations
Date: Fri, 07 Jun 2013 09:18:03 -0600	[thread overview]
Message-ID: <87fvwuuez8.fsf@gmail.com> (raw)
In-Reply-To: <CALn3zogxn2qj_WayBZJbWD+mEA2G3vaT78=9zTDp+oX5YZbCqw@mail.gmail.com> (Michael Brand's message of "Fri, 7 Jun 2013 16:53:10 +0200")

[-- Attachment #1: Type: text/plain, Size: 1512 bytes --]

Hi Michael,

>
> Is release_8.0.3-207-g5dc5143 the change you mention?:
>

yes

>
>     commit 5dc5143578a2759611a5856de9bf9d1c7eba9283
>     Author: Eric Schulte <schulte.eric@gmail.com>
>     Date:   Thu Jun 6 10:59:27 2013 -0600
>
>         inline sets org-babel-current-exec-src-block-head
>
> In this commit I see two issues which my patch does not have:
>
> 1) The variable name org-babel-current-exec-src-block-head is the same
>    as for a different meaning (source block head) and purpose introduced
>    in release_8.0.3-202-gf301bbc
>
>        commit f301bbcc862c2acc61749bc1e24895bf69cd4d06
>        Author: Vitalie Spinu <spinuvit@gmail.com>
>        Date:   Thu Jun 6 12:04:02 2013 +0200
>
>            make src block location available to execution backends
>
>    but in release_8.0.3-207-g5dc5143 the same name is used for the
>    point-marker of "call_func" which is misleading.

Perhaps the variable name should be updated, but this extension is
simply a generalization to include inline code blocks as well.  I don't
find it misleading.

>    In my patch I named the variable "loc" for Location Of Call.

In the technical pigeon spoken in my own circles loc has a well
established meaning, namely "line of code".

>    And I chose intentionally a name as short as possible to keep the
>    "#+HEADER:" lines not getting too wide, see e. g. the ERT in my
>    patch.
>
> 2) Export is not supported ("C-c C-c" works as expected).
>

I can't reproduce this bug.  The following Org-mode file.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: export-loc.org --]
[-- Type: text/x-org, Size: 438 bytes --]

# #+PROPERTY: exports results

# Two examples using `org-babel-current-exec-src-block-head'.

* head
  :PROPERTIES:
  :foo:      bar
  :END:

In a block.
#+name: head
#+begin_src emacs-lisp
  (org-entry-get org-babel-current-exec-src-block-head "foo")
#+end_src

In a call line.
#+call: head()

* tail
  :PROPERTIES:
  :foo:      baz
  :END:

#+begin_src emacs-lisp
  (org-entry-get org-babel-current-exec-src-block-head "foo")
#+end_src

[-- Attachment #3: Type: text/plain, Size: 1168 bytes --]


exports to the following latex

    % -*- latex -*-
    \section{head}
    \label{sec-1}

    In a block.
    \begin{verbatim}
    bar
    \end{verbatim}

    In a call line.
    \begin{verbatim}
    bar
    \end{verbatim}
    \section{tail}
    \label{sec-2}

    \begin{verbatim}
    baz
    \end{verbatim}

Although I think there may well be improvements to be made to the
current approach, e.g. a different variable name, or saving a list of
call locations instead of just the first call location, I've yet to see
a motivating example where the existing solution is inadequate.

Thanks,

>
> Just today I saw a possible improvement for my patch: For a more
> general usage of "loc" than only for org-entry-get it would be better
> if "loc" in export would not contain the location of the entry start
> but the exact location of possibly more than one call within the same
> entry. For "C-c C-c" this is already the case. Since I don't know how
> to resolve this I would let it as is for now unless there is a
> suggestion.
>
> I would like to provide a new patch if I know what else should be
> improved.
>
> Michael

-- 
Eric Schulte
http://cs.unm.edu/~eschulte

  reply	other threads:[~2013-06-07 15:18 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-22 17:03 link abbreviation with multiple params, e. g. for geo locations Michael Brand
2013-05-29 16:14 ` Michael Brand
2013-06-05 17:19   ` Michael Brand
2013-06-06 17:01 ` Eric Schulte
2013-06-07 14:53   ` Michael Brand
2013-06-07 15:18     ` Eric Schulte [this message]
2013-06-07 19:16       ` Michael Brand
2013-06-07 19:54         ` Vitalie Spinu
2013-06-08 18:05           ` Eric Schulte
2013-06-08 18:52             ` Vitalie Spinu
2013-06-08 19:21               ` Eric Schulte
2013-06-14 17:54                 ` Michael Brand
2013-06-14 18:18                   ` Eric Schulte
2013-06-14 20:13                     ` Michael Brand
2013-06-19  9:39                       ` Michael Brand
2013-06-07 20:10         ` Achim Gratz
2013-06-08 18:03         ` Eric Schulte
2013-06-09  7:56           ` Michael Brand
2013-06-09  8:07             ` Michael Brand
2013-06-09 19:18             ` Eric Schulte
2013-06-09 20:32               ` Michael Brand
2013-06-11 13:12                 ` Eric Schulte
  -- strict thread matches above, loose matches on Subject: below --
2013-05-05 15:06 Michael Brand
2013-05-06  7:06 ` Christian Moe
2013-05-06 18:42   ` Michael Brand
2013-05-06 22:29     ` Christian Moe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fvwuuez8.fsf@gmail.com \
    --to=schulte.eric@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=michael.ch.brand@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).