emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Eric Schulte <schulte.eric@gmail.com>
To: Daniele Pizzolli <dan@toel.it>
Cc: emacs-orgmode@gnu.org
Subject: Re: Tentative patch to keep org-babel-results-keyword when calling org-babel-remove-result
Date: Fri, 20 Sep 2013 16:30:45 -0600	[thread overview]
Message-ID: <87fvsz5dnu.fsf@gmail.com> (raw)
In-Reply-To: <523CC47D.8060807@toel.it> (Daniele Pizzolli's message of "Fri, 20 Sep 2013 23:56:13 +0200")

Hi Daniele,

Thanks for catching this very large edge case which I completely
ignored.  I've just pushed up a fix.

Best,

Daniele Pizzolli <dan@toel.it> writes:

> On 09/20/2013 11:13 PM, Eric Schulte wrote:
>> Hi Daniele,
>>
>> Thanks for the suggestion and the accompanying patch.  I've just applied
>> a modified version of your patch (included below).  Please let me know
>> if this is insufficient for your needs.
>
> Hello Eric,
>
> Wonderful! Your patch is perfect for my use case.  Thanks for the
> quick improvement!
>
> I just re-discovered the amazing feature of "named source blocks".
> that unfortunately trigger a corner case:
>
> #+NAME: fig1
> #+BEGIN_SRC...
> #+END_SRC
>
> Some text
>
> #+RESULTS: fig1
>
> ** Other section
>
> After running:
>
> (org-babel-map-src-blocks nil (org-babel-remove-result nil t))
>
> Will result in:
>
> #+NAME: fig1
> #+BEGIN_SRC...
> #+END_SRC
>
> Some text
>
> #+RESULTS: f
> ** Other section
>
> I tried to look at the code, but the level of indirection you added
> makes me feel lost.  I would be happy to help in testing, even with
> more use cases if needed.  I just found that the section “Writing
> tests with minimal Emacs-lisp knowledge” at
> http://orgmode.org/worg/org-tests/index.html#sec-3 is not yet complete
> but I can have a look at the source code and follow your advises or
> examples.
>
> Thanks again,
> Daniele Pizzolli
>

-- 
Eric Schulte
https://cs.unm.edu/~eschulte
PGP: 0x614CA05D

next prev parent reply	other threads:[~2013-09-20 22:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-20 20:28 Tentative patch to keep org-babel-results-keyword when calling org-babel-remove-result Daniele Pizzolli
2013-09-20 21:13 ` Eric Schulte
2013-09-20 21:56   ` Daniele Pizzolli
2013-09-20 22:30     ` Eric Schulte [this message]
2013-09-21  6:44       ` Daniele Pizzolli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fvsz5dnu.fsf@gmail.com \
    --to=schulte.eric@gmail.com \
    --cc=dan@toel.it \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).