From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: preview and default class [8.2.5h (release_8.2.5h-677-g55b0a3 @ /home/youngfrog/sourcetrees/org-mode/lisp/)] Date: Thu, 20 Mar 2014 11:55:45 +0100 Message-ID: <87fvmdyw9a.fsf@bzg.ath.cx> References: <87pplzbijh.fsf@yahoo.fr> <87y50euqc8.fsf@bzg.ath.cx> <87wqfpx1z5.fsf@yahoo.fr> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53715) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQadj-0002zy-1F for emacs-orgmode@gnu.org; Thu, 20 Mar 2014 06:56:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WQada-0001k6-Sv for emacs-orgmode@gnu.org; Thu, 20 Mar 2014 06:55:58 -0400 Received: from rs249.mailgun.us ([209.61.151.249]:52679) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQada-0001jv-L9 for emacs-orgmode@gnu.org; Thu, 20 Mar 2014 06:55:50 -0400 In-Reply-To: <87wqfpx1z5.fsf@yahoo.fr> (Nicolas Richard's message of "Wed, 19 Mar 2014 23:22:54 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Nicolas Richard Cc: emacs-orgmode@gnu.org Hi Nicolas, Nicolas Richard writes: > Here's a patch. I can commit it if you like, but I don't want to do so > without some review (it's not as trivial a change as moving the > corresponding footnote to the other section). I can't apply the patch, either on maint or on master, but by reading it carefully it looks good. Just add a missing full-stop at the end of the Changelog sentence "in its own section.", and perhaps use `C-x 4 a' from within the diff to include the section's name in the Changelog too. PS: I didn't check carefully because I don't use `C' from magit, but I assume magit may be wrong in creating Changelogs. We should report this to magit maintainers if this is true. -- Bastien