emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Achim Gratz <Stromeko@nexgo.de>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] ob-shell
Date: Mon, 23 Jun 2014 19:20:59 +0200	[thread overview]
Message-ID: <87fvivczk4.fsf@Rainer.invalid> (raw)
In-Reply-To: CACc7+8Z97drHZcYWJeMvAQnNrtxbTh+-Q5HySqcc2C8y0YC-NQ@mail.gmail.com

Pascal Fleury writes:
> I was wondering how it would behave if the string that is put into a
> variable contains newlines, backslashes and other things that bash
> (and other shells) treats specially.

Exactly like it does with the earlier method, except it doesn't fork and
doesn't require certain versions of bash.

> The trick with cat and BABEL_TABLE is resistant to this.

I don't think so, some older versions of bash had a parsing bug that
made it croak on single quotes in here documents.  Single quoting the
variable content only reuires special handling of single quotes.  While
that is tedious and error prone to do by hand, we're doing it with elisp
anyway so this doesn't pose a problem.  Also, it works for just about
any shell, not only those that know about $( ) command substitution and
implement here documents within the substitution correctly.

> As in many cases (when I use it at least) the variable come from other
> parts of the org file and are computed through another language
> (python in my case) I have such cases that would break.

If you have an example, please show it.

> Also, I think the test coverage for such things is limited for
> ob-shell.el in the org test suite.
> We should probably add some test cases for this, and then make sure it
> works with your implementation as well.

By all means, please add such tests.  While you're at it, you might want
to double quote the variable expansions, which will show you that the
shell is wholly capable of returning a list and even a table to Org,
with or without associative arrays.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Samples for the Waldorf Blofeld:
http://Synth.Stromeko.net/Downloads.html#BlofeldSamplesExtra

  reply	other threads:[~2014-06-23 17:21 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-22 10:03 2 Org tests failing Sebastien Vauban
2014-05-22 10:48 ` Bastien
     [not found]   ` <87tx8iks22.fsf-E3UqQZAQFPqWIDz0JBNUog@public.gmane.org>
2014-06-18 14:55     ` Sebastien Vauban
2014-06-18 21:49       ` Achim Gratz
2014-06-19  8:36         ` Sebastien Vauban
2014-06-19  9:04           ` Sebastien Vauban
2014-06-19  9:08             ` Sebastien Vauban
2014-06-19 20:05           ` Achim Gratz
2014-06-22  8:35             ` [PATCH] ob-shell (was: 2 Org tests failing) Achim Gratz
2014-06-22 12:50               ` [PATCH] ob-shell Eric Schulte
2014-06-23  6:26                 ` Pascal Fleury
2014-06-23 17:20                   ` Achim Gratz [this message]
2014-06-23 20:02                 ` Achim Gratz
2014-07-24  7:38                 ` Alan Schmitt
2014-08-04 11:56                   ` Eric Schulte
2014-08-04 19:48                   ` Achim Gratz
2014-08-13 13:12                     ` Alan Schmitt
2014-08-13 13:20                       ` Pascal Fleury
2014-08-13 13:29                         ` Alan Schmitt
2014-08-22  8:52                           ` Pascal Fleury
2014-08-22 13:08                             ` Pascal Fleury
2014-08-22 18:16                               ` Achim Gratz
2015-01-21 22:58                                 ` Pascal Fleury
2015-01-25 11:41                                   ` Achim Gratz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fvivczk4.fsf@Rainer.invalid \
    --to=stromeko@nexgo.de \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).