emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Moritz Kiefer <moritz.kiefer@gmail.com>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug: pdf page numbers in links are ignored when exporting to latex [8.2.7b (8.2.7b-13-gd8a0ee-elpa @ /home/moritz/.emacs.d/elpa/org-20140728/)]
Date: Fri, 01 Aug 2014 21:21:47 +0200	[thread overview]
Message-ID: <87fvhgypxj.fsf@gmail.com> (raw)
In-Reply-To: <87lhr8womu.fsf@nicolasgoaziou.fr>

[-- Attachment #1: Type: text/plain, Size: 152 bytes --]

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Hello,
> It's not. Thanks for the patch. Some comments follow.
Hi, tried to fix those issues.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-ox-latex.el-Add-page-number-of-link-when-exporting-t.patch --]
[-- Type: text/x-diff, Size: 1229 bytes --]

From 82cb7209c912798b43a91b3dde1dd4428e09580e Mon Sep 17 00:00:00 2001
From: Moritz Kiefer <moritz.kiefer@gmail.com>
Date: Thu, 31 Jul 2014 17:45:36 +0200
Subject: [PATCH] ox-latex.el: Add page number of link when exporting to latex

* lisp/ox-latex.el (org-latex--inline-image): Use page
number (:search-option) of pdf links as page option in

 lisp/ox-latex.el | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/lisp/ox-latex.el b/lisp/ox-latex.el
index ceea302..dd227ab 100644
--- a/lisp/ox-latex.el
+++ b/lisp/ox-latex.el
@@ -1861,6 +1861,12 @@ used as a communication channel."
 	(setq options (concat options ",width=" width)))
       (when (org-string-nw-p height)
 	(setq options (concat options ",height=" height)))
+      (let ((search-option (org-element-property :search-option link)))
+        (when (and search-option
+                   (equal filetype "pdf")
+                   (string-match "\\`[0-9]+\\'" search-option)
+                   (not (string-match "page=" options)))
+          (setq options (concat options ",page=" search-option))))
       (setq image-code
 	    (format "\\includegraphics%s{%s}"
 		    (cond ((not (org-string-nw-p options)) "")

  reply	other threads:[~2014-08-01 19:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-29 20:31 Moritz Kiefer
2014-07-30 20:30 ` Nicolas Goaziou
     [not found]   ` <87tx5xz2kr.fsf@gmail.com>
2014-08-01  9:22     ` Nicolas Goaziou
2014-08-01 19:21       ` Moritz Kiefer [this message]
2014-08-02  8:25         ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fvhgypxj.fsf@gmail.com \
    --to=moritz.kiefer@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=mail@nicolasgoaziou.fr \
    --subject='Re: Bug: pdf page numbers in links are ignored when exporting to latex [8.2.7b (8.2.7b-13-gd8a0ee-elpa @ /home/moritz/.emacs.d/elpa/org-20140728/)]' \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).