emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Teika Kazura <teika@gmx.com>
Cc: emacs-orgmode@gnu.org, bezjak.miro@gmail.com
Subject: Re: Bug (regression) in org-replace-disputed-keys. Bisected.
Date: Mon, 03 Nov 2014 21:54:42 +0100	[thread overview]
Message-ID: <87fve0c8dp.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <20141001.102227.1578863029392514259.teika@gmx.com> (Teika Kazura's message of "Wed, 01 Oct 2014 10:22:27 +0900 (JST)")

Hello,

Teika Kazura <teika@gmx.com> writes:

> Now a real fix. There're two candidates:
>
> (i) Revert the wrong commit. Since it was in fact done in two separate commits[2], you need another patch, not git-revert. Here it is:
> ------------------------------------------------------------------------
> diff -u -r org-8.2.7c-orig/lisp/org.el org-8.2.7c/lisp/org.el
> --- org-8.2.7c-orig/lisp/org.el	2014-09-30 18:10:54.485977061 +0900
> +++ org-8.2.7c/lisp/org.el	2014-09-30 18:11:24.293602328 +0900
> @@ -16220,8 +16220,7 @@
>  (defvar org-read-date-inactive)
>  
>  (defvar org-read-date-minibuffer-local-map
> -  (let* ((org-replace-disputed-keys nil)
> -	 (map (make-sparse-keymap)))
> +  (let* ((map (make-sparse-keymap)))
>      (set-keymap-parent map minibuffer-local-map)
>      (org-defkey map (kbd ".")
>                  (lambda () (interactive)
> ------------------------------------------------------------------------

I think this change is appropriate. Could you provide a patch with git
format-patch?


Regards,

-- 
Nicolas Goaziou

next prev parent reply	other threads:[~2014-11-03 20:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-09 11:42 Bug (regression) in org-replace-disputed-keys. Bisected Teika Kazura
2014-09-28 20:07 ` Nicolas Goaziou
2014-10-01  1:22   ` Teika Kazura
2014-11-03 20:54     ` Nicolas Goaziou [this message]
2014-11-12 11:49       ` [patch] " Teika Kazura
2014-11-13 22:32         ` Nicolas Goaziou
2014-11-14 22:29       ` Miro Bezjak
2014-11-18 21:32         ` Nicolas Goaziou
2014-11-19  9:50           ` Miro Bezjak
  -- strict thread matches above, loose matches on Subject: below --
2014-09-17  8:42 Teika Kazura

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fve0c8dp.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=bezjak.miro@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=teika@gmx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).