From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [PATCH] ox-html.el: add exporting of priority
Date: Fri, 09 Jan 2015 09:20:49 +0100
Message-ID: <87fvbkpdpa.fsf@nicolasgoaziou.fr>
References: <CAGJcBOcdX-OXg68uCK6DpRqh9abMZ=Rd2hn1B=-gqak3z5GoNw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50460)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1Y9UnQ-0002sd-Jf
	for emacs-orgmode@gnu.org; Fri, 09 Jan 2015 03:19:53 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1Y9UnM-00076K-J6
	for emacs-orgmode@gnu.org; Fri, 09 Jan 2015 03:19:52 -0500
Received: from relay6-d.mail.gandi.net ([2001:4b98:c:538::198]:34471)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1Y9UnM-00076D-D5
	for emacs-orgmode@gnu.org; Fri, 09 Jan 2015 03:19:48 -0500
In-Reply-To: <CAGJcBOcdX-OXg68uCK6DpRqh9abMZ=Rd2hn1B=-gqak3z5GoNw@mail.gmail.com>
	(Zane D. Purvis's message of "Thu, 8 Jan 2015 22:23:38 -0500")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: "Zane D. Purvis" <zane.purvis@gmail.com>
Cc: emacs-orgmode@gnu.org

Hello,

"Zane D. Purvis" <zane.purvis@gmail.com> writes:

Thanks for the patch.

The summary line should be capitalized, i.e.,

  ox-html: Add exporting of priority

> * list/ox-html.el (org-html--priority): new function

Capitalize, too.

> (org-html-format-headline-default-function): call `org-html--priority'

Ditto.

> (org-html-style-default): add `.priority'

Ditto.

> +(defun org-html--priority (priority info)
> +  "Format a priority into HTML.
> +PRIORITY is the character code of the priority or nil.
> +INFO is a plist containing export options."
> +  (when priority
> +    (format "<span class=\"priority\">[%s]</span>"
> +        (byte-to-string priority))))

Shorter:

  (and priority (format "<span class=\"priority\">[%c]</span>" priority))

Could you fix these issues before I apply your patch?


Regards,

-- 
Nicolas Goaziou