From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Rasmus <rasmus@gmx.us>
Cc: emacs-orgmode@gnu.org
Subject: Re: [patch] better(?) indention for cdlatex-environment
Date: Wed, 11 Feb 2015 22:39:32 +0100 [thread overview]
Message-ID: <87fvacw2jv.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87lhk48z9x.fsf@gmx.us> (rasmus@gmx.us's message of "Wed, 11 Feb 2015 12:26:34 +0100")
Rasmus <rasmus@gmx.us> writes:
> Indeed that this the trick. The attached patch seems to work nicely and
> takes care of the corner cases I could think of.
>
> I now get the following (desirable) behavior
>
> - key :: foo | bar
> baz
> # insert latex-environment with cdlatex
>
> - key :: foo | bar
> \begin{ENV}
> whatever
> \end{ENV}
> baz
I don't see how it is desirable. The logical behaviour is to split the
line, unless, of course, docstring clearly specifies this.
AFAICT `cdlatex-environment' splits the line. Is there a particular
reason for `org-cdlatex-environment-indent' to proceed differently?
> Here's another case
> p1
> - item | item
> p2
> # insert latex-environment with cdlatex
> p1
> - item item
> \begin{equation}
> \label{eq:9}
>
> \end{equation}
Ditto.
> + ;; TODO: Cleanup if quit. Unfortunately `cdlatex-environment'
> + ;; always return nil.
What do you want to clean up? In what situations? Can't `unwind-protect'
help you?
> + (let* (;; Insert environment on next line unless at beginning of line.
Comments starting with ";;" need to be on a line on their own.
> + (eol
> + (unless (<= (point)
> + (save-excursion (beginning-of-line)
> + (org-skip-whitespace)
> + (point)))
Nitpick:
(unless (save-excursion (skip-chars-backward " \t") (bolp))
...)
> + (end-of-line) t))
> + ;; Get correct indention for next line.
> + (ind (if eol (save-excursion
> + (org-return-indent)
> + (prog1 (org-get-indentation)
> + (unless (or (eobp) (looking-at "[^ \t]"))
Nitpick: (org-looking-at-p "\\S-")
> + (kill-whole-line))))
There's no need to pollute the kill ring.
(delete-region (line-beginning-position) (line-end-position))
Anyway, why bother?
Regards,
next prev parent reply other threads:[~2015-02-11 21:38 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-10 11:28 [patch] better(?) indention for cdlatex-environment Rasmus
2015-02-10 12:27 ` Rasmus
2015-02-10 22:35 ` Nicolas Goaziou
2015-02-11 11:26 ` Rasmus
2015-02-11 21:39 ` Nicolas Goaziou [this message]
2015-02-11 23:40 ` Rasmus
2015-02-13 22:10 ` Nicolas Goaziou
2015-02-13 23:13 ` Rasmus
2015-02-14 0:29 ` Rasmus
2015-02-14 21:20 ` Nicolas Goaziou
2015-02-15 0:08 ` Rasmus
2015-02-15 9:52 ` Nicolas Goaziou
2015-02-17 0:41 ` Rasmus
2015-02-17 8:51 ` Nicolas Goaziou
2015-02-17 21:19 ` Rasmus
2015-02-18 0:39 ` Nicolas Goaziou
2015-02-18 1:06 ` Rasmus
2015-02-19 0:22 ` Rasmus
2015-02-19 23:11 ` Rasmus
2015-02-19 23:23 ` Nicolas Goaziou
2015-02-19 23:32 ` Rasmus
2015-02-20 0:13 ` Nicolas Goaziou
2015-02-20 0:38 ` Rasmus
2015-02-20 10:16 ` Nicolas Goaziou
2015-02-20 10:35 ` Rasmus
2015-02-20 10:40 ` Nicolas Goaziou
2015-02-20 10:43 ` Rasmus
2015-02-20 10:49 ` Nicolas Goaziou
2015-02-20 10:54 ` Rasmus
2015-02-20 11:17 ` Nicolas Goaziou
2015-02-20 10:50 ` Rasmus
2015-02-14 1:10 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fvacw2jv.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=rasmus@gmx.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).