From mboxrd@z Thu Jan  1 00:00:00 1970
From: Aaron Ecay <aaronecay@gmail.com>
Subject: Re: [PATCH 9/9] ob-calc: don't leave garbage on the stack
Date: Wed, 04 Nov 2015 11:31:03 +0000
Message-ID: <87fv0mvw5k.fsf@gmail.com>
References: <1446581747-1960-1-git-send-email-oxij@oxij.org>
	<1446581747-1960-10-git-send-email-oxij@oxij.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34932)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aaronecay@gmail.com>) id 1ZtwHV-0003nz-Ki
	for emacs-orgmode@gnu.org; Wed, 04 Nov 2015 06:31:10 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aaronecay@gmail.com>) id 1ZtwHR-0004Ws-PB
	for emacs-orgmode@gnu.org; Wed, 04 Nov 2015 06:31:09 -0500
Received: from mail-wm0-x22b.google.com ([2a00:1450:400c:c09::22b]:38380)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aaronecay@gmail.com>) id 1ZtwHR-0004Wl-IQ
	for emacs-orgmode@gnu.org; Wed, 04 Nov 2015 06:31:05 -0500
Received: by wmeg8 with SMTP id g8so38829459wme.1
	for <emacs-orgmode@gnu.org>; Wed, 04 Nov 2015 03:31:05 -0800 (PST)
In-Reply-To: <1446581747-1960-10-git-send-email-oxij@oxij.org>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: emacs-orgmode@gnu.org
Cc: Jan Malakhovski <oxij@oxij.org>

Hi Jan,

2015ko azaroak 3an, Jan Malakhovski-ek idatzi zuen:
>=20
> * lisp/ob-calc.el (org-babel-calc-eval-string): Clean up the stack after =
expression
>   evaluation.
> ---
>  lisp/ob-calc.el | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>=20
> diff --git a/lisp/ob-calc.el b/lisp/ob-calc.el
> index e8b43e7..2656f27 100644
> --- a/lisp/ob-calc.el
> +++ b/lisp/ob-calc.el
> @@ -196,7 +196,9 @@ See `org-babel-calc-eval' for more info."
>    (mapc #'org-babel-calc-eval-line (split-string text "[\n\r]"))
>    (save-excursion
>      (with-current-buffer (get-buffer "*Calculator*")
> -      (calc-eval (calc-top 1)))))
> +      (prog1
> +        (calc-eval (calc-top 1)

Are you missing a close paren at the end of the above line?  Also,
shouldn=E2=80=99t calc-eval take a string as an argument, not a lisp form? =
 (I=E2=80=99m
asking based on the docstring, I don=E2=80=99t know the calc API at all).

--=20
Aaron Ecay