From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Rasmus <rasmus@gmx.us>
Cc: emacs-orgmode@gnu.org
Subject: Re: extra paragraph in image export?
Date: Tue, 24 Jan 2017 22:27:39 +0100 [thread overview]
Message-ID: <87fuk86tdg.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87sho8ztgv.fsf@gmx.us> (rasmus@gmx.us's message of "Tue, 24 Jan 2017 10:40:32 +0100")
[-- Attachment #1: Type: text/plain, Size: 567 bytes --]
Hello,
Rasmus <rasmus@gmx.us> writes:
> I'm not an expert of HTML either. However, the "p" tag inside the
> "figure" is uncommon looking a bit on the example usages online. Thus, I
> agree with Matt that it should probably not be there.
OK.
> AFAIK, the CSS selector still differs so on the output side they are not
> alike. I.e. the former is "figure>img" the other is a "p>img". Aside: If
> anything, removing the "p" tag inside the figure would make it easier to
> handle images.
So would the following patch fix the issue?
Regards,
--
Nicolas Goaziou
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-ox-html-Remove-p-tag-around-block-images-when-using-.patch --]
[-- Type: text/x-diff, Size: 971 bytes --]
From 49ebd5a8406bdee0c0a94b83f7135d94e35bb6ba Mon Sep 17 00:00:00 2001
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Date: Tue, 24 Jan 2017 22:22:47 +0100
Subject: [PATCH] ox-html: Remove <p> tag around block images when using HTML5
* lisp/ox-html.el (org-html--wrap-image): Do not add a spurious <p>
tag when using <figure> to mark images.
---
lisp/ox-html.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/ox-html.el b/lisp/ox-html.el
index d3c1b2eb1..fa8476a05 100644
--- a/lisp/ox-html.el
+++ b/lisp/ox-html.el
@@ -1607,7 +1607,7 @@ arguments CAPTION and LABEL are given, use them for caption and
;; ID.
(if (org-string-nw-p label) (format " id=\"%s\"" label) "")
;; Contents.
- (format "\n<p>%s</p>" contents)
+ (if html5-fancy contents (format "\n<p>%s</p>" contents))
;; Caption.
(if (not (org-string-nw-p caption)) ""
(format (if html5-fancy "\n<figcaption>%s</figcaption>"
--
2.11.0
next prev parent reply other threads:[~2017-01-24 21:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-21 16:26 extra paragraph in image export? Matt Price
2017-01-21 23:09 ` Matt Price
2017-01-22 13:18 ` Nicolas Goaziou
2017-01-24 9:40 ` Rasmus
2017-01-24 21:27 ` Nicolas Goaziou [this message]
2017-01-25 3:57 ` Matt Price
2017-01-25 4:04 ` Matt Price
2017-01-25 13:13 ` Nicolas Goaziou
2017-01-25 14:59 ` Rasmus
2017-01-25 15:01 ` Rasmus
2017-01-25 16:59 ` Nicolas Goaziou
2017-01-25 18:02 ` Matt Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fuk86tdg.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=rasmus@gmx.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).