From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: emacs-orgmode@gnu.org
Subject: Re: TIMEZONE property for ical export
Date: Sat, 19 Aug 2017 12:56:40 -0700 [thread overview]
Message-ID: <87fucns553.fsf@ericabrahamsen.net> (raw)
In-Reply-To: 87k21zjr6x.fsf@nicolasgoaziou.fr
Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>>> BTW, as long as Org doesn't support time zones, the "ox-icalendar"
>>> property may be prefixed with "ICALENDAR_" (e.g., ICALENDAR_TZ).
>>
>> Done!
>
> I realize this is not a great idea since other properties do not have
> "ICALENDAR_" prefix. Sorry about that. I suggest to go back to TIMEZONE.
No problem.
>> How does the attached patch look?
>
>> - (cat (org-icalendar-get-categories entry info)))
>> + (cat (org-icalendar-get-categories entry info))
>> + (tz (org-element-property :ICALENDAR_TZ entry)))
>
> Note that "ICALENDAR_TZ" is not inherited in this case. Neither are
> LOCATION and so on, tho. You would need to use
> `org-export-get-node-property' in conjunction with
> `org-property-inherit-p'.
It's a little strange, because the manual section for this specifically
mentions the inheritance of the LOCATION property, but the code doesn't
do it. Shall I add it in? It makes sense for LOCATION and TIMEZONE to be
inheritable, but not SUMMARY and DESCRIPTION, of course.
If I add inheritance, that will look like this, right?
(tz (org-export-get-node-property :LOCATION entry
(org-property-inherit-p :LOCATION)))
That could also be a separate, second commit.
>> -event belongs to.
>> +event belongs to. TIMEZONE specifies a time zone for this event
>> +only.
>
> Missing space.
>
> Could you add a commit message and an ORG-NEWS entry?
I've added an ORG-NEWS entry. The patch in my last message was done with
git format-patch, isn't that commit message okay?
Eric
next prev parent reply other threads:[~2017-08-19 19:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-18 16:53 TIMEZONE property for ical export Eric Abrahamsen
2017-08-19 8:34 ` Nicolas Goaziou
2017-08-19 17:13 ` Eric Abrahamsen
2017-08-19 19:25 ` Nicolas Goaziou
2017-08-19 19:56 ` Eric Abrahamsen [this message]
2017-08-19 21:20 ` Nicolas Goaziou
2017-08-19 21:54 ` Eric Abrahamsen
2017-08-19 22:14 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fucns553.fsf@ericabrahamsen.net \
--to=eric@ericabrahamsen.net \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).