From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Allen Li <vianchielfaura@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug: org-attach-directory should be safe [9.1.3 (9.1.3-10-gadfbfd-elpaplus @ /home/ionasal/.emacs.d/elpa/org-plus-contrib-20171127/)]
Date: Mon, 04 Dec 2017 14:56:33 +0100 [thread overview]
Message-ID: <87fu8q8ulq.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CAJr1M6d+OtUZYSJ++xxeEj=Tz0KwbbVHUSRBAn6iWpggUZTKUg@mail.gmail.com> (Allen Li's message of "Sun, 3 Dec 2017 15:35:05 -0800")
Hello,
Allen Li <vianchielfaura@gmail.com> writes:
> org-attach-directory should be safe to set as a file local or
> directory local string.
>
> This allows the user to set a directory local attachment directory for
> all Org files in a directory tree recursively.
>
> I do not believe there are any security issues to enable arbitrary Org
> files to set org-attach-directory to a string value as the user would
> have to explicitly initiate any attach operations. The most dangerous
> thing I can think of is an Org file setting the attachment directory
> to the user's home directory and the user running the command to
> delete all attachments.
Fair enough. I added a :safe keyword to the defcustom.
Regards,
--
Nicolas Goaziou
prev parent reply other threads:[~2017-12-04 13:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-03 23:35 Bug: org-attach-directory should be safe [9.1.3 (9.1.3-10-gadfbfd-elpaplus @ /home/ionasal/.emacs.d/elpa/org-plus-contrib-20171127/)] Allen Li
2017-12-04 13:56 ` Nicolas Goaziou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fu8q8ulq.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=vianchielfaura@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).