From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: point moves and zoom level reverts when refreshing agenda Date: Tue, 19 Jun 2018 20:22:40 +0200 Message-ID: <87fu1ieivj.fsf@nicolasgoaziou.fr> References: <84vab61lf3.fsf@gmail.com> <841sdlco5v.fsf@gmail.com> <84r2llas45.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:40363) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fVLHD-00031Q-Mu for emacs-orgmode@gnu.org; Tue, 19 Jun 2018 14:22:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fVLH9-0003Vz-P4 for emacs-orgmode@gnu.org; Tue, 19 Jun 2018 14:22:47 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:57127) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fVLH9-0003VM-I6 for emacs-orgmode@gnu.org; Tue, 19 Jun 2018 14:22:43 -0400 In-Reply-To: <84r2llas45.fsf@gmail.com> (Marco Wahl's message of "Tue, 05 Jun 2018 22:35:54 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Marco Wahl Cc: emacs-orgmode@gnu.org Hello, Marco Wahl writes: > Hopefully Nicolas and Bastien see it the same way. Thank you. It looks good. Feel free to apply it. I have two suggestions however: 1. There is some code duplication, e.g., (dolist ...), could this be factored out before applying the patch? 2. Would it make sense to add the variables to preserve in a dedicated top-level variable instead of burying them in the code? Regards, -- Nicolas Goaziou