From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [PATCH] org: Support creating arbitrary headline paths when
 refiling
Date: Wed, 10 Oct 2018 12:49:32 +0200
Message-ID: <87ftxecc03.fsf@nicolasgoaziou.fr>
References: <20181007135831.26003-1-seb@wirrsal.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48383)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1gAC3g-0005qV-Dn
	for emacs-orgmode@gnu.org; Wed, 10 Oct 2018 06:49:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1gAC3c-0007Bf-DM
	for emacs-orgmode@gnu.org; Wed, 10 Oct 2018 06:49:40 -0400
Received: from relay2-d.mail.gandi.net ([217.70.183.194]:39161)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
	id 1gAC3c-00075Q-6E
	for emacs-orgmode@gnu.org; Wed, 10 Oct 2018 06:49:36 -0400
In-Reply-To: <20181007135831.26003-1-seb@wirrsal.net> ("Sebastian
	=?utf-8?Q?Reu=C3=9Fe=22's?=
	message of "Sun, 7 Oct 2018 15:58:31 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Sebastian =?utf-8?Q?Reu=C3=9Fe?= <seb@wirrsal.net>
Cc: emacs-orgmode@gnu.org

Hello,

Sebastian Reu=C3=9Fe <seb@wirrsal.net> writes:

> * org.el (org--refile-new-path): Add.
> (org-refile): Use it.
> (org-refile-new-child): Make new nodes more compact.
>
> * test-org.el (test-org/org-refile): Add test.
>
> While =E2=80=98org-refile=E2=80=99 currently supports creating new headli=
nes when
> refiling, only one single headline can be created this way. For
> convenience, we now generalize this use-case to support creating
> arbitrary headline paths on the fly.

Compiling your patch generates the following warnings.

    org.el:11417:1:Warning: Unused lexical variable =E2=80=98parent=E2=80=99
    org.el:11417:1:Warning: Unused lexical variable =E2=80=98child=E2=80=99
    org.el:11417:1:Warning: Unused lexical variable =E2=80=98parent-target=
=E2=80=99

Also, I couldn't test it because completing asks for a mandatory match
among candidates. Such a match is not possible if you need to create
a path out of the blue. Am I missing something?

Regards,

--=20
Nicolas Goaziou