From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bastien <bzg@gnu.org>
Subject: Re: Document backward-incompatible change in ORG-NEWS?
Date: Tue, 25 Feb 2020 20:34:51 +0100
Message-ID: <87fteyea04.fsf@gnu.org>
References: <87o8tofq1b.fsf@gmail.com> <87lfosz8ai.fsf@gnu.org>
 <87lfosfave.fsf@gmail.com> <87zhd8mba7.fsf@gnu.org>
 <87imjwf2ee.fsf@gmail.com> <874kvf67wd.fsf_-_@gnu.org>
 <87mu97c9sd.fsf@nicolasgoaziou.fr>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:33921)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <bzg@gnu.org>) id 1j6fyq-0003pp-9N
 for emacs-orgmode@gnu.org; Tue, 25 Feb 2020 14:34:57 -0500
In-Reply-To: <87mu97c9sd.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of
 "Tue, 25 Feb 2020 10:10:10 +0100")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org
Sender: "Emacs-orgmode"
 <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: Org Mode <emacs-orgmode@gnu.org>

Hi Nicolas,

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> You are right. This deserves an entry in ORG-NEWS.

thanks for your feedback, I've added this entry:
https://code.orgmode.org/bzg/org-mode/commit/1a84a8b611

> I think this is inefficient. It would be better to search directly for
>
>   (format "\\[\\[\\*%s\\s-+" (regexp-opt org-todo-keywords-1 t))

Indeed... I've pushed a simpler version, feel free to enhance it.

>> 	  (setq new (replace-regexp-in-string
>> 		     (concat (regexp-opt org-todo-keywords-1) "\\s-+")
>> 		     "" raw))
>> 	  (set-text-properties 0 (length new) nil new)
>
> Why do you remove all text properties? Also, see `org-no-properties'.

For the record, it seems that completing-read fifth argument cannot
be a string with properties - at least from the quick test I did.

Thanks,

-- 
 Bastien