From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: "Kévin Le Gouguec" <kevin.legouguec@gmail.com>
Cc: Org Mode list <emacs-orgmode@gnu.org>,
Emacs developers <emacs-devel@gnu.org>
Subject: Re: [PATCH] Make RET and C-j obey `electric-indent-mode' in org-mode
Date: Thu, 07 May 2020 12:48:16 +0200 [thread overview]
Message-ID: <87ftcc9g27.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <877dxpazbo.fsf_-_@gmail.com> (=?utf-8?Q?=22K=C3=A9vin?= Le Gouguec"'s message of "Wed, 06 May 2020 16:54:35 +0200")
Hello,
Kévin Le Gouguec <kevin.legouguec@gmail.com> writes:
> Here's a complete patch to make RET and C-j honor electric-indent-mode
> in org-mode, targeting Org's master branch.
Thank you very much.
I fixed a typo and applied your patch.
> +(defmacro org-test-with-minor-mode (mode state &rest body)
> + "Run BODY after setting MODE to STATE.
> +Restore MODE to its former state afterward."
> + (declare (debug (sexp sexp body)) (indent 2))
> + `(let ((old-state ,mode))
> + (,mode (if ,state 1 0))
> + ,@body
> + (,mode (if old-state 1 0))))
This is a nice macro.
However, when I have to reproduce a failing test, I don't even want to
think about the recipe and rather concentrate on the results. Hence,
I expect `should' macro's body to be self-sufficient. Therefore,
I skipped this part of the patch.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2020-05-07 10:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CADwFkm=qkNCWA40ieZ9Dv-gbk6xAzjG16sOa64GT+Zbv9pCC_A@mail.gmail.com>
[not found] ` <20200426172206.GC18629@ACM>
[not found] ` <87y2qhnc9a.fsf@gmail.com>
[not found] ` <20200427102311.GA4976@ACM>
[not found] ` <87mu6xtano.fsf@gmail.com>
[not found] ` <87k120ohsq.fsf@mail.linkov.net>
[not found] ` <87blnbir01.fsf@nicolasgoaziou.fr>
[not found] ` <87o8rbmbfa.fsf@mail.linkov.net>
[not found] ` <87k11yftqo.fsf@nicolasgoaziou.fr>
[not found] ` <87pnbqo74t.fsf_-_@gmail.com>
2020-04-29 12:30 ` Reconciling org-mode idiosyncrasies with Emacs core Nicolas Goaziou
2020-05-04 10:45 ` Kévin Le Gouguec
2020-05-04 14:50 ` Nicolas Goaziou
2020-05-04 16:14 ` Kévin Le Gouguec
2020-05-06 14:54 ` [PATCH] Make RET and C-j obey `electric-indent-mode' in org-mode (was: Reconciling org-mode idiosyncrasies with Emacs core) Kévin Le Gouguec
2020-05-07 10:48 ` Nicolas Goaziou [this message]
2020-05-07 12:03 ` [PATCH] Make RET and C-j obey `electric-indent-mode' in org-mode Kévin Le Gouguec
2020-05-07 12:21 ` Nicolas Goaziou
2020-05-07 16:45 ` Kévin Le Gouguec
2020-05-07 16:50 ` Kévin Le Gouguec
2020-05-07 19:38 ` Nicolas Goaziou
2020-05-24 6:25 ` Bastien
2020-05-07 13:53 ` Stefan Monnier
2020-05-07 15:33 ` Kévin Le Gouguec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftcc9g27.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-devel@gnu.org \
--cc=emacs-orgmode@gnu.org \
--cc=kevin.legouguec@gmail.com \
--subject='Re: [PATCH] Make RET and C-j obey `electric-indent-mode'\'' in org-mode' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox:
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).