From: Kyle Meyer <firstname.lastname@example.org> To: TEC <email@example.com> Cc: Jens Lechtenboerger <firstname.lastname@example.org>, Bastien <email@example.com>, org-mode-email <firstname.lastname@example.org> Subject: Re: [PATCH] Enhance org-html--build-meta-info Date: Wed, 20 Jan 2021 23:05:59 -0500 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <firstname.lastname@example.org> (TEC's message of "Thu, 14 Jan 2021 18:36:54 +0800") TEC writes: > TEC <email@example.com> writes: > > Sorry about that, here's an actual revision. Thanks, this series is a good improvement as far as I can tell. And thank you Jens for all of the careful reviews. I've applied this (a8df7670c) with two minor changes (shown in the diff at end): s/with with/with/ in a docstring and move an element to its own line to avoid the warning from lisp-mode's lisp--match-hidden-arg. This thread has gone on long enough that I'll avoid requesting changes for convention/style nits, but some things to keep in mind for future patches: * Your changes replace several `and's with `when's as well as a one-armed if. The previous code is following the style/preference of using `and' in cases where the return value is of interest, leaving `when' for side effects. As mentioned in the message below (just the first example I found when searching the list), it's definitely a matter of taste and not a hard rule, but please try to stick with that convention. https://firstname.lastname@example.org/ * Please avoid adding blank lines within function definitions. * Please follow the project's convention of capitalizing the first word after "<file/area>: " in the commit message subject. Also, it'd be good for this to be accompanied by a NEWS entry. I'd appreciated if that were sent in a separate thread, though. For some reason I haven't debugged, my usual MUA can't load this thread. Thanks again. diff --git a/lisp/ox-html.el b/lisp/ox-html.el index bd2ca1753..11757bb35 100644 --- a/lisp/ox-html.el +++ b/lisp/ox-html.el @@ -1431,8 +1431,8 @@ (defcustom org-html-meta-tags #'org-html-meta-tags-default Can be a list where each item is a list of arguments to be passed to `org-html--build-meta-entry'. Any nil items are ignored. -Also accept a function which gives such a list when called with with -a single argument (INFO, a communication plist)." +Also accept a function which gives such a list when called with a +single argument (INFO, a communication plist)." :group 'org-export-html :package-version '(Org . "9.5") :type '(choice @@ -1937,7 +1937,8 @@ (defun org-html--build-meta-info (info) (lambda (args) (apply #'org-html--build-meta-entry args)) (delq nil (if (functionp org-html-meta-tags) (funcall org-html-meta-tags info) - org-html-meta-tags)) "")))) + org-html-meta-tags)) + "")))) (defun org-html--build-head (info) "Return information for the <head>..</head> of the HTML output.
next prev parent reply other threads:[~2021-01-21 4:06 UTC|newest] Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-17 13:50 TEC 2020-09-17 14:21 ` TEC 2020-09-17 15:53 ` Jens Lechtenboerger 2020-09-17 16:14 ` TEC 2020-09-18 8:11 ` Jens Lechtenboerger 2020-09-25 17:48 ` TEC 2020-09-27 15:17 ` Jens Lechtenboerger 2020-09-27 17:39 ` TEC 2020-09-27 18:00 ` Jens Lechtenboerger 2020-09-27 18:35 ` TEC 2020-09-28 8:17 ` Jens Lechtenboerger 2020-12-13 16:12 ` TEC 2020-12-14 6:04 ` Bastien 2020-12-14 6:34 ` TEC 2020-12-14 7:20 ` Bastien 2020-12-14 7:27 ` TEC 2020-12-14 8:11 ` Bastien 2020-12-14 10:01 ` TEC 2020-12-14 9:49 ` Jens Lechtenboerger 2020-12-15 11:39 ` TEC 2020-12-16 4:13 ` Tom Gillespie 2020-12-16 5:04 ` Timothy E Chapman 2020-12-16 6:45 ` Tom Gillespie 2020-12-16 6:55 ` Jens Lechtenboerger 2020-12-16 7:22 ` TEC 2020-12-16 8:37 ` Jens Lechtenboerger 2020-12-20 5:08 ` TEC 2020-12-20 5:08 ` TEC 2020-12-20 17:59 ` Jens Lechtenboerger 2021-01-02 18:51 ` TEC 2021-01-03 13:26 ` Jens Lechtenboerger 2021-01-03 14:48 ` TEC 2021-01-03 15:41 ` Jens Lechtenboerger 2021-01-03 17:17 ` TEC 2021-01-04 7:11 ` Jens Lechtenboerger 2021-01-10 15:52 ` TEC 2021-01-10 17:02 ` Jens Lechtenboerger 2021-01-10 20:36 ` TEC 2021-01-14 10:36 ` TEC 2021-01-14 15:59 ` Jens Lechtenboerger 2021-01-14 16:02 ` Ready to merge! " TEC 2021-01-21 4:05 ` Kyle Meyer [this message] 2021-01-21 5:55 ` TEC
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH] Enhance org-html--build-meta-info' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).