From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id aG9gDsBHRmIfswAAgWs5BA (envelope-from ) for ; Fri, 01 Apr 2022 02:30:56 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id sDgRC8BHRmKRAAAAauVa8A (envelope-from ) for ; Fri, 01 Apr 2022 02:30:56 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3D626DD5A for ; Fri, 1 Apr 2022 02:30:55 +0200 (CEST) Received: from localhost ([::1]:45658 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1na5Bm-0005BL-1X for larch@yhetil.org; Thu, 31 Mar 2022 20:30:54 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60998) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1na59S-0005B8-1K for emacs-orgmode@gnu.org; Thu, 31 Mar 2022 20:28:30 -0400 Received: from sanpietro.red-bean.com ([45.79.25.59]:54632) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1na596-0000YS-It for emacs-orgmode@gnu.org; Thu, 31 Mar 2022 20:28:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=red-bean.com; s=202005newsp; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:Reply-To:References:Subject:Cc:To:From:Sender: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ib8sPKrczqbDsqI/g3BNk6zw4K6ODodAC6AfbCRtmMY=; t=1648772887; x=1649982487; b=hXOykSAnPj5TDa31UWryq4hvdYRB2g4hJ92lg8MtPJrDcurqnWN7v4w0ST3Dj3Cbf24UDaebCg0 3v4pvkGIBFWyM2axXCN5trftjLfeX2x94mNW51r7J/tKAKfxgboxALt40q5FsbHZ28TqwDc9m7eGb b9uGN+DmlocslfX6G37Bz7Wx4QYdAV1l3ddIwYepSAIRUV+G1qBZUUzTOs4J4YVvJTuH5DqZkIqjg DH4oBo/+acY3TyMagey63iDr8x1rXKo6YXs6xafUw4oPUc6vJiZThfbz5tucD1XIxE0RkQ8SCMCWT p0IXrfbbmoDeQZfXjGC+cdLSF382CNqui+Ew==; Received: from 99-112-125-163.lightspeed.cicril.sbcglobal.net ([99.112.125.163]:35468 helo=floss) by sanpietro.red-bean.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1na593-004fO5-6T; Fri, 01 Apr 2022 00:28:06 +0000 From: Karl Fogel To: Org Mode Subject: Re: Removing obsolete function `org-truely-invisible-p'. References: <87czmcccrp.fsf@red-bean.com> <87h7b5rm6f.fsf@localhost> Date: Thu, 31 Mar 2022 19:28:05 -0500 In-Reply-To: <87h7b5rm6f.fsf@localhost> (Ihor Radchenko's message of "Sun, 19 Dec 2021 17:14:32 +0800") Message-ID: <87fsmx8x62.fsf@red-bean.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=45.79.25.59; envelope-from=kfogel@red-bean.com; helo=sanpietro.red-bean.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Karl Fogel Cc: Ihor Radchenko Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1648773056; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=ib8sPKrczqbDsqI/g3BNk6zw4K6ODodAC6AfbCRtmMY=; b=D+SxkoqWp1uSXnF6bmLHWMPsXMzQjCD+4Tp0lP1hPWt3qkh42HNQ6wr6w/hXatugMk4xDD LmMBTMc6bwZj3y/ytIX7g4jjXLgucQUlg6iem3V8Uf+L67+ZzH4YO9Xy8hrqZk003dGre5 c0UIpCs1fWWWfNxdJMKaNxBp5Szepp9X4DCPgTMVTAFQR+MBnavM98SjPOaKnIcxLK3nHl 6bBQ8DR6NMQGGSEVpeEqWP2xO/9M0R16vTQvKIx4IgW/CJsFwljiCeFtAvT4+i0s01/ay7 PFDR0SRlp+hK9+t57MAp1Sbs6/pnzfkxNsI7U3rIpA4juPALK2nwr8Z+pocqMQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1648773056; a=rsa-sha256; cv=none; b=K+2PX0eCb+9e2QR+oOV7eovRgEudT1B9S8o8ag2I6G+Spqhlis8X3GJPXWUv2CDOzOKPbg 5fA45aL22mZ//ApRwlFPVlBXHJzrFk0yZZ+mrMrp7HONmYh76qJ4KnH1MumzKWAIS067ZV HamGsCo/BhfUf0AoKszZO2Q8kaDb0leBbBCCn78T/Z0IFxQYqfpAU2nzVDdvN7/UMluave JXFf/56hnml5KsVNrX9Pq0ykz7cP9sVZfGQP05L29S/WbKNZ+5Bbe6kI2kWymHkhc5EyIn vB9F6R7ZZCYKvYTBg++eFw728/XC3/H0B48S5iey5ODmM3YJx6d6Na/r2fivDQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=red-bean.com header.s=202005newsp header.b=hXOykSAn; dmarc=fail reason="SPF not aligned (relaxed)" header.from=red-bean.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 6.13 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=red-bean.com header.s=202005newsp header.b=hXOykSAn; dmarc=fail reason="SPF not aligned (relaxed)" header.from=red-bean.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 3D626DD5A X-Spam-Score: 6.13 X-Migadu-Scanner: scn1.migadu.com X-TUID: YgAqHJE+rVVb --=-=-= Content-Type: text/plain; format=flowed On 19 Dec 2021, Ihor Radchenko wrote: >Karl Fogel writes: > >> Should we just remove `org-truely-invisible-p'? Or at least >> correct the spelling of its name ("truely" should be "truly")? > >I feel slightly reluctant about removal. If nothing, this >function can >be a reminder about visible-mode and keeping it has little >downside. >Though if others think that removing would be better, I would >also be >fine with it. > >Renaming sounds reasonable. Just need to define obsolete alias >for the >old name in org-compat.el. > >Could you prepare a patch? Having a patch may encourage more >feedback. Sure; please see attached. Best regards, -Karl --=-=-= Content-Type: text/plain Content-Disposition: attachment; filename=0001-Mark-function-obsolete-fix-spelling-of-its-name.patch >From bb229b4f8f78ae52962d7bc90c8b1d4993af8263 Mon Sep 17 00:00:00 2001 From: Karl Fogel Date: Thu, 31 Mar 2022 19:02:38 -0500 Subject: [PATCH] Mark function obsolete & fix spelling of its name * lisp/org-macs.el (org-truely-invisible-p): Move to... * lisp/org-compat.el (org-truly-invisible-p): ...here, and add... (org-truely-invisible-p): ...this compatibility alias. There are no callers of this function in Org Mode, nor in current Emacs (on the 'master and 'emacs-28' branches at least). We discussed whether to remove it entirely, and for now seem to have tentatively decided not to remove it. See this thread for more details: From: Ihor Radchenko Subject: Re: Removing obsolete function `org-truely-invisible-p'. To: Karl Fogel Cc: Org Mode Date: Sun, 19 Dec 2021 17:14:32 +0800 Message-ID: <87h7b5rm6f.fsf@localhost> --- lisp/org-compat.el | 12 ++++++++++++ lisp/org-macs.el | 7 ------- 2 files changed, 12 insertions(+), 7 deletions(-) diff --git lisp/org-compat.el lisp/org-compat.el index 38d330de6..43d44211e 100644 --- lisp/org-compat.el +++ lisp/org-compat.el @@ -402,6 +402,18 @@ See `org-link-parameters' for documentation on the other parameters." (make-obsolete 'org-add-link-type "use `org-link-set-parameters' instead." "9.0") ;;;; Functions unused in Org core. + +;; Not used since commit 3baf246f4f (Nicolas Goaziou, 2016-04-28) +(defun org-truly-invisible-p () + "Check if point is at a character currently not visible. +This version does not only check the character property, but also +`visible-mode'." + (unless (bound-and-true-p visible-mode) + (org-invisible-p))) +(define-obsolete-function-alias 'org-truely-invisible-p + 'org-truly-invisible-p "2022-03-31" + "Compatibility alias for legacy misspelling of `org-truly-invisible-p'.") + (defun org-table-recognize-table.el () "If there is a table.el table nearby, recognize it and move into it." (when (org-at-table.el-p) diff --git lisp/org-macs.el lisp/org-macs.el index b39af9103..fb3c441e1 100644 --- lisp/org-macs.el +++ lisp/org-macs.el @@ -1151,13 +1151,6 @@ fontification." (folding-only (memq value '(org-hide-block outline))) (t value)))) -(defun org-truely-invisible-p () - "Check if point is at a character currently not visible. -This version does not only check the character property, but also -`visible-mode'." - (unless (bound-and-true-p visible-mode) - (org-invisible-p))) - (defun org-invisible-p2 () "Check if point is at a character currently not visible. If the point is at EOL (and not at the beginning of a buffer too), -- 2.35.1 --=-=-=--