emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Small patch for org-refile
@ 2022-04-21  9:50 Kambiz Darabi
  2022-04-21 13:55 ` Ihor Radchenko
  0 siblings, 1 reply; 3+ messages in thread
From: Kambiz Darabi @ 2022-04-21  9:50 UTC (permalink / raw)
  To: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 427 bytes --]

Hello,

I recently switched to Emacs 28 and stumpled upon a call in org-refile to
define-obsolete-function-alias which doesn't have the 'when' parameter.
As Emacs 28 has made the 'when' parameter mandatory, this is a problem
for me.

Attached is a tiny patch against the git repo which I cloned today which
resolves the problem.

Thanks for your great work


Kambiz

PS: please keep me in Cc as I'm not subscribed to the list


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: org-refile patch --]
[-- Type: text/x-diff, Size: 762 bytes --]

From 9b2ac43338945022418389168835a5cd2cc2adcd Mon Sep 17 00:00:00 2001
From: Kambiz Darabi <darabi@m-creations.net>
Date: Thu, 21 Apr 2022 10:29:13 +0200
Subject: [PATCH] org-refile: add 'when' param to obsolete org-copy

---
 lisp/org-refile.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/org-refile.el b/lisp/org-refile.el
index a8a2ef2a6..ee19788fc 100644
--- a/lisp/org-refile.el
+++ b/lisp/org-refile.el
@@ -373,7 +373,7 @@ the *old* location.")
 (defvar org-refile-keep nil
   "Non-nil means `org-refile' will copy instead of refile.")
 
-(define-obsolete-function-alias 'org-copy 'org-refile-copy)
+(define-obsolete-function-alias 'org-copy 'org-refile-copy "Org 9.4")
 
 ;;;###autoload
 (defun org-refile-copy ()
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Small patch for org-refile
  2022-04-21  9:50 Small patch for org-refile Kambiz Darabi
@ 2022-04-21 13:55 ` Ihor Radchenko
  2022-04-21 14:46   ` Kambiz Darabi
  0 siblings, 1 reply; 3+ messages in thread
From: Ihor Radchenko @ 2022-04-21 13:55 UTC (permalink / raw)
  To: Kambiz Darabi; +Cc: emacs-orgmode

Kambiz Darabi <darabi@m-creations.net> writes:

> I recently switched to Emacs 28 and stumpled upon a call in org-refile to
> define-obsolete-function-alias which doesn't have the 'when' parameter.
> As Emacs 28 has made the 'when' parameter mandatory, this is a problem
> for me.
>
> Attached is a tiny patch against the git repo which I cloned today which
> resolves the problem.
>
> Thanks for your great work

Are you sure that you cloned the repo we mention at
https://orgmode.org/?

The change you are suggesting is already in Org 9.5.3 and that alias has
been moved to org-compact.el long time ago.

Best,
Ihor


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Small patch for org-refile
  2022-04-21 13:55 ` Ihor Radchenko
@ 2022-04-21 14:46   ` Kambiz Darabi
  0 siblings, 0 replies; 3+ messages in thread
From: Kambiz Darabi @ 2022-04-21 14:46 UTC (permalink / raw)
  To: emacs-orgmode

Hi,

On 2022-04-21 21:55 +08, Ihor Radchenko <yantar92@gmail.com> wrote:

> Are you sure that you cloned the repo we mention at
> https://orgmode.org/?
>
> The change you are suggesting is already in Org 9.5.3 and that alias has
> been moved to org-compact.el long time ago.

awfully sorry for the noise!

I manage my packages with straight and thought I had checked out the
latest tag, while I hadn't.

Thanks


Kambiz


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-04-21 14:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-21  9:50 Small patch for org-refile Kambiz Darabi
2022-04-21 13:55 ` Ihor Radchenko
2022-04-21 14:46   ` Kambiz Darabi

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).