emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [BUG] markdown blocks remain visible when they should be folded
@ 2022-05-28  0:50 Tom Gillespie
  2022-05-28  1:41 ` Ihor Radchenko
  0 siblings, 1 reply; 3+ messages in thread
From: Tom Gillespie @ 2022-05-28  0:50 UTC (permalink / raw)
  To: emacs-orgmode, Ihor Radchenko

One of the commits between
ffdc508429c58716272743c0e0650bb721fd906a (good) and
67275f4664ce00b5263c75398d78816e7dc2ffa6 (bad)
a change was introduced that broke folding for markdown
blocks. I'm not sure of the exact commit because folding
is completely broken for all the commits in between.

Looking at the diff between the two there are so many
changes involving the invisible text property that I have no
idea which one is the culprit.

The markdown blocks remain visible and have the invisible
text property set to nil, when folded #+end_src will turn into
... but the markdown remains visible. The whole block will
be left open if any of the markdown list or heading chars are
present in the block.

Here are some examples that trigger the issue:

* a
#+begin_src markdown
1.
#+end_src
* b
#+begin_src markdown
-
#+end_src
* c
#+begin_src markdown
# hello
#+end_src


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [BUG] markdown blocks remain visible when they should be folded
  2022-05-28  0:50 [BUG] markdown blocks remain visible when they should be folded Tom Gillespie
@ 2022-05-28  1:41 ` Ihor Radchenko
  2022-05-28  2:22   ` Tom Gillespie
  0 siblings, 1 reply; 3+ messages in thread
From: Ihor Radchenko @ 2022-05-28  1:41 UTC (permalink / raw)
  To: Tom Gillespie; +Cc: emacs-orgmode

Tom Gillespie <tgbugs@gmail.com> writes:

> The markdown blocks remain visible and have the invisible
> text property set to nil, when folded #+end_src will turn into
> ... but the markdown remains visible. The whole block will
> be left open if any of the markdown list or heading chars are
> present in the block.
> ...
> * c
> #+begin_src markdown
> # hello
> #+end_src

Fixed on main via 66528468a.

Best,
Ihor


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [BUG] markdown blocks remain visible when they should be folded
  2022-05-28  1:41 ` Ihor Radchenko
@ 2022-05-28  2:22   ` Tom Gillespie
  0 siblings, 0 replies; 3+ messages in thread
From: Tom Gillespie @ 2022-05-28  2:22 UTC (permalink / raw)
  To: Ihor Radchenko; +Cc: emacs-orgmode

Confirming fixed. Many thanks!
Tom


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-05-28  2:23 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-28  0:50 [BUG] markdown blocks remain visible when they should be folded Tom Gillespie
2022-05-28  1:41 ` Ihor Radchenko
2022-05-28  2:22   ` Tom Gillespie

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).