From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id +AK4Gl6JBGSxQAEAbAwnHQ (envelope-from ) for ; Sun, 05 Mar 2023 13:21:50 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id KJXOGV6JBGRIRQEAG6o9tA (envelope-from ) for ; Sun, 05 Mar 2023 13:21:50 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 25DC02E5A6 for ; Sun, 5 Mar 2023 13:21:50 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pYnMb-0004zE-Sh; Sun, 05 Mar 2023 07:21:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYnMa-0004xH-6D for emacs-orgmode@gnu.org; Sun, 05 Mar 2023 07:21:16 -0500 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYnMX-0002sg-Qx for emacs-orgmode@gnu.org; Sun, 05 Mar 2023 07:21:15 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 950D9240134 for ; Sun, 5 Mar 2023 13:21:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1678018870; bh=l3oUc/xm4ckqzfSn+5WmTTEE/QjExCJHtDKNKlti1Bw=; h=From:To:Cc:Subject:Date:From; b=hyvEwujEoNm3mKP055tZyFK+nHlZlHMiIrksf+eHTnp0Aech2MT7AjkgWiJLD1CZ4 1hsWwCBBHDI8zpCGzDBW0pha16tsvaMBbmfQkfpyrv1u5yUBnzzzZvjextpWm0O6ID LA28/nMkee2es5HkVkV6wjH52CLigC+cgbt/q7AH/urjTAEnd8X6xu60GkmFgemgBK mvNMSt+blKuhU6CJm/xCaSmdVV9erLh+g45evX2O5t7cRymmTVpsMd+VWrdpM0hNMr XVzYMtjKb8hr3slUA+UFTnB6h5V1W0W0bn1EoqUrhoIvbtq+j8uuF7ExUZmF/Mrun5 aQ+nvr/6X2B1A== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4PV15d6M5Dz9rxK; Sun, 5 Mar 2023 13:21:09 +0100 (CET) From: Ihor Radchenko To: Rudolf =?utf-8?Q?Adamkovi=C4=8D?= Cc: Max Nikulin , emacs-orgmode@gnu.org Subject: Re: [PATCH] org-clock: Add a trailing space to the mode line string In-Reply-To: References: <20230302141443.7842-1-salutis@me.com> <87r0u54ygh.fsf@localhost> Date: Sun, 05 Mar 2023 12:22:34 +0000 Message-ID: <87fsajz8tx.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1678018910; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=l3oUc/xm4ckqzfSn+5WmTTEE/QjExCJHtDKNKlti1Bw=; b=ZJUB3waj4dI4xkWFecAHUCW7DxmfppfIUNV9M0WlUyR6GA0Dm8Ac/YXFm/kL1d1R9zBZja cSCJwsLH5HlwII8xBw9xazYaOGcGPSX2f/aZRuxbFWlQeedUEMPF8oZYuCaI3G6n+dtoxC AtJVyqMQDKMGpXmJu4AEudd2meQ9AX+xJcM1r+cUwqX2LH8Q+K+ltGKz2sgQ+dpXxVgqpw Em+3IRGtDliQ0HbMHvzfGIShUhdqZYOAAjxOyFBMA1LR8nc+NnuKKm8Rr4rY96U1gySUek btNmnKJ5a1ADv+tHE8cW1z7tCaYgY0T2H+2LHcc8QARiNOb/8WySVCT9WF+tNw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=hyvEwujE; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1678018910; a=rsa-sha256; cv=none; b=dZs/hJYd4gar7JoS7A5znAMe3hpjtKWoyVAd3nMGOYRKVR4NHu/icrEbUhiVQTUoOXIxp0 WipAPEfhWO1vao0wtFX7CN8TdXXOWmmZyOo/yeZnYNxffYGGuyZQZ6bSMv8np83lGP7u3+ 41BBGmSTxGM/6/Z00xlQKldU5qpOwqr9Ie5H0kqKrnBnqy5KncXchdmeMTK+jZgptpoU7R wEviHP2rkLOuwXDXtw6OYTD3THAOo8gw54Qd67nx1oGJauBrY7KiG+YLhW9uii4szBvrvD oLykjZvO8+WrlLZGa4u3YciMJbrHqtQGTR3W59+cia8mnejBwCIjIgPEpENlqg== X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -4.70 X-Spam-Score: -4.70 X-Migadu-Queue-Id: 25DC02E5A6 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=hyvEwujE; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net X-TUID: uuuqgUdQ8tf8 Rudolf Adamkovi=C4=8D writes: > Please see the attached patch, revised as follows: > > - no leading space in the mode line element to make it completely correct > - a clear explanation (with a citation) to avoid pointless discussions > - two new automated tests to avoid future regressions > - a clearer commit message > Thanks! Applied, onto bugfix. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=3D3d817c52c --=20 Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at