From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id +BrXKYaThWTwLAAASxT56A (envelope-from ) for ; Sun, 11 Jun 2023 11:27:34 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id uOh3KIaThWSKEgAAG6o9tA (envelope-from ) for ; Sun, 11 Jun 2023 11:27:34 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3367713054 for ; Sun, 11 Jun 2023 11:27:34 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q8HLJ-0000ZF-Ht; Sun, 11 Jun 2023 05:26:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q8HLH-0000X8-6f for emacs-orgmode@gnu.org; Sun, 11 Jun 2023 05:26:35 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q8HLF-0001Df-AR for emacs-orgmode@gnu.org; Sun, 11 Jun 2023 05:26:34 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 0732F240101 for ; Sun, 11 Jun 2023 11:26:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1686475592; bh=9xMPp1WNPdhwIobubkqCX1Bnb6YpKTe9HKGQA+E5tKE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=T4H7RC90AyRx39EEP/nUNlLEc8tvarknYjy9mdX/3oP3vAYkZ3q/ykXblUGBorkS/ oEDW5bbvmh1ipzHCtPuZ7wVTvC3PfrH2amWRRSxgfDzFdH/eqBLr+aefY7B+J25Dfc xixE9E8rsSiMtvbve4yI3qzGszToSzxDDLUKjkeaDfHYiU0pv/bbvyyh4FUQ7XhfPO enFIvZMhwyuBsjq1evr1TxemiqHO/mGOiOnyuBfV+Y7gwgwTBnWoxua2qD4Zw6bBYz LUWUBmB/56+VeOrKZfFgSpsR/IztX4f0r1MuHHlWG1+Ew3806lRWvjlJdS3M6QWDot 8kl4IQRmeY0QA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Qf8Zv0tmlz9rxD; Sun, 11 Jun 2023 11:26:30 +0200 (CEST) From: Ihor Radchenko To: David Masterson Cc: emacs-orgmode@gnu.org Subject: Re: Is this proper time format? In-Reply-To: References: <87r0qplm9y.fsf@localhost> <87ilc1ktrx.fsf@localhost> <875y7y2qga.fsf@localhost> <87h6rh140j.fsf@localhost> <87v8fvtz1u.fsf@localhost> Date: Sun, 11 Jun 2023 09:31:23 +0000 Message-ID: <87fs6ytkes.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1686475654; a=rsa-sha256; cv=none; b=r4/SCjfnhMmpDbeM+8V5puAwWQ1Ibba5xSRXlOswjHeJvuP89xnX7B7WQSgYUrN1vG9tjb S5yPd44J0rHTJp869SqmWHBhreICvIQaHW6sNTvouR46cxIosTZSkROI2Np/T2lbV0ZdOg hRkOfLV0g6C6r9QIkU1geWGuBwqnY7szydQVOSgMJkpgD7ayOD+D0EUg7QblVSriK1hjKp PjjOu4F4pF08L6+ioAisOx4nkyDy5dr0M9luMEk+gsLDEGsBLcnCIhOGbR7TBrGp+1CsGl HirT9CkczXGX5bNShRbLesT7HamtA7Cko5Co1JUfwC3OJzPKtjrGsVnak1lmYA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=T4H7RC90; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1686475654; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=pHr+m6tJlBWYZ7oeMApoJvbcXY+67QFHAgpmt+pB1B8=; b=M3RFp6EC6LaOQIUkceU6UE2wYAZLAZwjxk7xm1tLPcjWZd5/zAWTelMXeEFxtGxqcaTziy qbRDqLS5HF0DT+VM1ClSgVbzpwBq482M83tmfyEZLBkddkszhFUrJ9tDPEDo5df4YkAuCJ O9YijMTGxivdcoDnbZaDpedxttixny3DCCb/Fmn0yQrQxyuNXuFw4utlVNGsfu+6UJNQY/ xB8ZgVf5kB1Nei69EZSPjwbjpcXyHhaQhnICqGNkYtyHSZydNjHtfRDkNpTz2zkeL5Nb/1 U2pcVua5VkkX+pDonnLwFqYy/CdfSYd6IN4UNyrCT0fsNmQbC7LtIVfyrq7obw== Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=T4H7RC90; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -6.48 X-Spam-Score: -6.48 X-Migadu-Queue-Id: 3367713054 X-TUID: 11M+jINfBSt2 David Masterson writes: >> Yes. Though it would be better to attach the diff with proper (.diff or >> .patch) extension. > > I hope you saw that I provided a "patch,txt" file in a following message > (forgot about the naming convention -- been a long time...) Inline and attachment are both fine. >> Even better would be providing commit message and formatting the patch >> properly. See https://orgmode.org/worg/org-contribute.html#first-patch >> Not mandatory though - I can format things properly on your behalf. > > Thank you. I haven't "patched" anything on Savannah and assumed I might > have to do the GNU copyright assignment. For this, I thought it would > be easy for you. Yes and no. One of the things you get to do when creating a proper patch is commit message describing the changes in detail. This helps to review your own changes and often helps with silly typos. So, it is generally not hard for me to write the commit message on your behalf, but if you do it yourself, it generally makes life easier for me when reviewing changes. As for copyright assignment, it does not matter if you provide a diff or patch - the work is yours and it is a subject of copyright rules we use. <=15LOC of non-trivial changes does not require copyright assignment. >>> -#+cindex: timestamps >>> -#+cindex: ranges, time >>> -#+cindex: date stamps >>> -#+cindex: deadlines >>> -#+cindex: scheduling >> >> Is there any particular reason why you removed index entries here and >> further in the diff? > > No, there isn't. I think what happened here is that I noticed section > 8.1 in org-guide and org-manual were almost (but not quite) the same. I > assumed (incorrectly?) that they were supposed to be the same, but got > out of sync. So I made my patch to org-guide and then replaced section > 8.1 in org-manual with the one from org-guide. I think these "cindex" > statements got dropped because of that. If they are important in > org-manual, but not org-guide, then please put them back. Well. They are kind of out of sync. But the org-guide is not supposed to be exact copy of the manual - the guide only contains the most important parts. That's why footnotes are dropped. For cindex entries, they are not needed in the guide. #+cindex and similar keywords are just anchors to build concept/variable/command index in the manual. We do not have such index in the guide. >> Why did you remove hours? > > Oh! Another difference between org-guide and org-manual that came over > in trying to resync the two. This is a valid out-of-sync entry. I updated the guide now. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=e9d6a5479 > I'm relooking at this patch. Testing finds that these work in the > timegrid agenda as expected: > > * <2023-02-03 Thu 10:00-11:00>--<2023-02-04 Fri 10:00-11:00> > ** Can't mark one done -- you have to mark them all done > *** Kind of expected for this form > * <2023-02-03 Thu 10:00-11:00 +1d> > ** Can you limit the number of repeats? If so, how? Only using diary sexp. Limiting the repeater intervals is one of the feature requests we have. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at