From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id QF9sCJdTyGVnYAEAqHPOHw:P1 (envelope-from ) for ; Sun, 11 Feb 2024 05:56:55 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id QF9sCJdTyGVnYAEAqHPOHw (envelope-from ) for ; Sun, 11 Feb 2024 05:56:55 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=martinmarshall-com.20230601.gappssmtp.com header.s=20230601 header.b=Uo8MWa9u; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1707627414; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=sBcbZBhD6Y0swi7hQxtnAZCdM8AlTf3ajRa3Ixavya0=; b=n6pyr0f2JfitBjkE+Wjft+9iLk+VmThNnA0s54FWysOr0hDCVQsm0vKoJCL90jUq0tqj3j LQIXaPMVOk6RyBYXeQVaZCHnD04St9A52vlAuG2QFT0cV4JesyQ2kkj0JiGqpBy0oTLXhS exZr4bx5k1oPig+BzcRvR4hq+qXLnolHAYM/eHKYdjQq2Kj8Ca3lDtQ1574aLHINEjJMn9 PEiy+A8RqwplB8aagTB9qN/hZMii9rnZuZ+rQIJIkA2zoj3D6AtIW5s4uaqaENc1icHXJo Y5Q/q6TC2ZOT7cbhYsdAeeN4BNAiSH2urlxWQQUGqLr/QPW/+8kyJApGfNAiFw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=martinmarshall-com.20230601.gappssmtp.com header.s=20230601 header.b=Uo8MWa9u; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1707627414; a=rsa-sha256; cv=none; b=RA9cRZP8WwKrmt2Ra5GnLxe1jXmz7fmTwhYxhSHViT005poXW3pl9SCPSWgqjvMi8yWRBl 8wqs8lytrL6/0PlIWPJ2hnmIqUWFlUN9aQsQhq5DV5vyFYrz6gq1OREqAPix0YD5FPh35Z 6MQdmEpno9sY/l2LJ987r/Ipyn9A/Yaazuh2bxjLuRE3GHTSxXUdwMcqVR5b3KcuRo4jJz EgnLWVt6VJneb/iImznWFFdcBNtD79nsRqpUPw/eKIuN4kK8jkZFHXPGpoyGFQeugxJzGG 9I+Dr5a2dT4wHL8kckNijQgmGKmDPfQLlHHg3WKIjLojLjE4C0vhcjsE9acrVw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C0871220F1 for ; Sun, 11 Feb 2024 05:56:54 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rZ1sf-0005IF-Vx; Sat, 10 Feb 2024 23:55:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZ1se-0005I1-P7 for emacs-orgmode@gnu.org; Sat, 10 Feb 2024 23:55:52 -0500 Received: from mail-yb1-xb33.google.com ([2607:f8b0:4864:20::b33]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rZ1sc-0003eI-Qy for emacs-orgmode@gnu.org; Sat, 10 Feb 2024 23:55:52 -0500 Received: by mail-yb1-xb33.google.com with SMTP id 3f1490d57ef6-dc754853524so1643038276.3 for ; Sat, 10 Feb 2024 20:55:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=martinmarshall-com.20230601.gappssmtp.com; s=20230601; t=1707627349; x=1708232149; darn=gnu.org; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=sBcbZBhD6Y0swi7hQxtnAZCdM8AlTf3ajRa3Ixavya0=; b=Uo8MWa9uIKDXFWttxYdUSTQPywhp+IWPaBCaXTVPZ5fdPTdrtm7GmVsvPdpkLXQbKr GRMfWKZj1nU/qqNgtgTKavv0f4OXgl8vVIqFiykoSoyVvCgI6U0XvFbZZmQi/7wGl6kY dW9KBYTAItfb7QPFTg5Us4jKVASlYABdh1hA1vurxG5n+1qCRCkiugxcJgHgep4O9G+h YnhWVe35iFZXVFWFBI40OTBqng3wDE4Aw6oyH9I1yITn/QICxcTtiS+hXutWLhoUalWG 1G04kvetIm/hkxw7DXp7/nVGvhDCW0BUaiWpfbHVYCePGy9KQW6UA8IWfOK3CRvKPUhH y5CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707627349; x=1708232149; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=sBcbZBhD6Y0swi7hQxtnAZCdM8AlTf3ajRa3Ixavya0=; b=HN5LzEF3Hk/sGzGiDg1T+TGFKgxYB/KmGqObvomV/imFgHsnFl2Fnr5cWFsCotRkln sy78ZYJSWZsIf/p9lH1S1LQTfdEEt+8kH3t7yfbW83ujPpLJ/dzZd9hYndqBkl5ksJs3 n/LNusaelfTwOL8fQTRu0n/Ow9MCDela95Hhsfna5bpdINRK/EZ8hNOSEGrRtmvW8/Oe EaL9sTyj5LudOpmNVK4TYnslnknRLNV9GWtAA9tBkDVMUMxHND5z0ZmYuJ0jnCFIPjbG SYNoZYed/PXFTiH4z5CfDHX/Bay2db7cf9TVotTKg0LeAM7q7IWK63M32io2ixY2Ascv /Hlg== X-Gm-Message-State: AOJu0YzYA7MqXrSmeL1xZ64MO5nSvi3Iy4wEiPlHZGsHQIE7a/EEcqSW ODfBO+XX/72TaASIQfP2LWhTm3v/D7zIISxj+b2KN0CMejErN9g+S+gv2sPphG25YqgwnqH0I/k = X-Google-Smtp-Source: AGHT+IFgcRFSXKB2CXRlLRwanQZjpg2tCQ3CvIIgaX1XQ/3tzrA4JFrc0cKsprbJZtPv6nWMd8LxEg== X-Received: by 2002:a25:abad:0:b0:dc2:5553:ca12 with SMTP id v42-20020a25abad000000b00dc25553ca12mr3036080ybi.14.1707627348759; Sat, 10 Feb 2024 20:55:48 -0800 (PST) Received: from vader (68-252-220-225.lightspeed.tukrga.sbcglobal.net. [68.252.220.225]) by smtp.gmail.com with ESMTPSA id b11-20020a25ae8b000000b00dc6d07c4064sm798459ybj.41.2024.02.10.20.55.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Feb 2024 20:55:48 -0800 (PST) From: Martin Marshall To: emacs-orgmode@gnu.org Subject: [PATCH] org-ctags: When `ido-mode' is off, use completing-read Date: Sat, 10 Feb 2024 23:55:47 -0500 Message-ID: <87frxzr44s.fsf@martinmarshall.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: none client-ip=2607:f8b0:4864:20::b33; envelope-from=law@martinmarshall.com; helo=mail-yb1-xb33.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -9.31 X-Spam-Score: -9.31 X-Migadu-Queue-Id: C0871220F1 X-Migadu-Scanner: mx12.migadu.com X-TUID: P1vn4lg2p+tw --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-org-ctags-Use-completing-read-if-ido-mode-is-off.patch Content-Description: Improve completion for org-ctags-find-tag-interactive >From 24d731457433b333b28845e6140532bad790800e Mon Sep 17 00:00:00 2001 From: Martin Marshall Date: Sat, 10 Feb 2024 23:02:34 -0500 Subject: [PATCH] org-ctags: Use `completing-read' if `ido-mode' is off * org-ctags.el (org-ctags-find-tag-interactive): Only use `ido-completing-read' if `ido-mode' is enabled, otherwise use `completing-read'. --- lisp/org-ctags.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lisp/org-ctags.el b/lisp/org-ctags.el index 9d9028704..a825bd7cf 100644 --- a/lisp/org-ctags.el +++ b/lisp/org-ctags.el @@ -510,7 +510,8 @@ Uses `ido-mode' if available. If the user enters a string that does not match an existing tag, create a new topic." (interactive) - (let* ((tag (ido-completing-read "Topic: " org-ctags-tag-list + (let* ((compfunc (if ido-mode 'ido-completing-read 'completing-read)) + (tag (funcall compfunc "Topic: " org-ctags-tag-list nil 'confirm nil 'org-ctags-find-tag-history))) (when tag (cond -- 2.39.2 --=-=-= Content-Type: text/plain Here's another patch for org-ctags.el. `org-ctags-find-tag-interactive' uses `ido-completing-read' for selecting and jumping to a target. This patch makes it use `completing-read' instead, unless the user enabled `ido-mode'. -- Best regards, Martin Marshall --=-=-=--