emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: Karthik Chikmagalur <karthikchikmagalur@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [BUG] Attachments not resolved correctly from symlinked Org files
Date: Fri, 14 Jun 2024 11:44:15 +0000	[thread overview]
Message-ID: <87frtflpf4.fsf@localhost> (raw)
In-Reply-To: <87mso1oxvs.fsf@localhost>

Ihor Radchenko <yantar92@posteo.net> writes:

> Ihor Radchenko <yantar92@posteo.net> writes:
>
>> What about the approach we already use in
>> `org-attach-id-to-path-function-list' - check if an attachment directory
>> already exists, generated using any rule, and only if not, create a new?
>>
>> Similarly, in `org-attach-dir', we can first check local attachment
>> directory and return it if it exists. Then, we check attachment
>> directory for the symlink source, and return it when it exists.
>> If none exists, create attachment locally or relative to the symlink
>> source, according to some customization. The default will be creating
>> locally, to follow the existing behavior.
>
> See the attached tentative patch.

Applied, onto main.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=1686b6f3b

As for creating attachment directories in the symlink source dir, I
suggest posting a feature request. Then, we will see if such a feature
would be useful for people.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


      reply	other threads:[~2024-06-14 11:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-28 20:22 [BUG] Attachments not resolved correctly from symlinked Org files Karthik Chikmagalur
2024-04-30  9:09 ` Ihor Radchenko
2024-05-01 15:18   ` Karthik Chikmagalur
2024-05-04  7:52     ` Ihor Radchenko
2024-06-04  9:33       ` Ihor Radchenko
2024-06-14 11:44         ` Ihor Radchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87frtflpf4.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=emacs-orgmode@gnu.org \
    --cc=karthikchikmagalur@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).