emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: "Eric Schulte" <schulte.eric@gmail.com>
To: Eric S Fraga <e.fraga@ucl.ac.uk>
Cc: Litvinov Sergey <slitvinov@gmail.com>, emacs-orgmode@gnu.org
Subject: Re: [babel] maxima support?
Date: Tue, 15 Mar 2011 11:27:32 -0600	[thread overview]
Message-ID: <87ei681egr.fsf@gmail.com> (raw)
In-Reply-To: <87d3lss5h7.fsf@ucl.ac.uk> (Eric S. Fraga's message of "Tue, 15 Mar 2011 16:39:32 +0000")

Eric S Fraga <e.fraga@ucl.ac.uk> writes:

> "Eric Schulte" <schulte.eric@gmail.com> writes:
>
>> Eric S Fraga <e.fraga@ucl.ac.uk> writes:
>>
>>> "Eric Schulte" <schulte.eric@gmail.com> writes:
>>>
>>> [...]
>>>
>>>>
>>>> Ah, I see the problem, I used let instead of let*.  Please try this
>>>> updated version of the patch.  Sorry I would test this myself, but I
>>>> don't have Maxima installed.
>>>
>>> No problem at all!  I'm happy to test this as many times as necessary.
>>>
>>> In any case, this works fine in that maxima is indeed evaluated and
>>> output is returned.  However, two problems arise:
>>>
>>> 1. lines of the form "rat: replaced XXX by YYY = ZZZ" are not deleted
>>>    (as used to be by the grep -v replaced hack I had in the original
>>>    ob-maxima).  Essentially, we need to ignore output lines that match
>>>    the regex "^rat: replaced .*$" (I think this should do it...).
>>>
>>> 2. The output is converted to an org table:
>>>
>>
>> The attached should fix both of these problems.  Please let me know how
>> this works.
>
> Eric,
>
> Well, it didn't work :(.  
>
> However, I think I managed to fix it.  I think you have an ulterior
> motive: to make me learn elisp properly once and for all... ;-).
>

sure... that must be the reason I've put all these bugs in the code
   /looking around suspiciously/

>
> Attached is the updated ob-maxima.el file with two changes:
>
> 1. quoted =identity= in the =mapconcat= sexp.
> 2. asked =split-string= to split on newlines so that (a) the regex for
>    the rat line would match *and* (b) so that the output is faithful to
>    what maxima generates.
>
> I hope these make sense!  I've gone through the code and I think I
> understand it.  More importantly, the output is now essentially the same
> as I was getting before which makes me quite happy.
>

Great, these changes look good, I've just push this up to the org-mode
repository.

Thanks for contributing support for a new language! -- Eric

>
> I'll do some more testing but the various tests I have tried should
> cover most aspects that I ever use.
>
> Thanks,
> eric

next prev parent reply	other threads:[~2011-03-15 17:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-23  9:32 [babel] maxima support? Litvinov Sergey
2011-02-24 10:25 ` Eric S Fraga
2011-02-24 10:28   ` Eric S Fraga
2011-02-25  9:17   ` Litvinov Sergey
2011-02-25 23:58   ` Eric Schulte
2011-02-28 16:15     ` Eric S Fraga
2011-03-14 21:26       ` Eric Schulte
2011-03-15 10:47         ` Eric S Fraga
2011-03-15 13:17           ` Eric Schulte
2011-03-15 14:27             ` Eric S Fraga
2011-03-15 15:32               ` Eric Schulte
2011-03-15 16:39                 ` Eric S Fraga
2011-03-15 17:27                   ` Eric Schulte [this message]
2011-03-15 18:32                     ` Eric S Fraga

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ei681egr.fsf@gmail.com \
    --to=schulte.eric@gmail.com \
    --cc=e.fraga@ucl.ac.uk \
    --cc=emacs-orgmode@gnu.org \
    --cc=slitvinov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).