emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-end-of-meta-data-and-drawers
Date: Thu, 30 Jun 2011 20:46:36 -0400	[thread overview]
Message-ID: <87ei2alteb.fsf@ericabrahamsen.net> (raw)
In-Reply-To: 87k4c3z4sd.fsf@gnu.org

On Thu, Jun 30 2011, Bastien wrote:

> Hi Eric,
> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>> Currently, this function goes to a lot of trouble to concatenate a
>> complicated regexp to find metadata and drawers, and then doesn't use
>> it. As it stands, if you put point in a headline that has a property
>> drawer and then call =(org-end-of-meta-data-and-drawers)=, point moves
>> to the *beginning* of the property drawer -- obviously not what you
>> want.
> you're right there was something weird in this function.
> I just simplified it, inspired by your patch.  Thanks 
> for this!

Thanks, but this introduces new problems for me -- the regexp matches on
every line, so it trucks along past both drawers and regular text to the
next heading, and stops there. I think the test for the drawer end is
necessary, which probably means the regexp grouping is also necessary…


PS My own use case (another version of org word count) didn't rely on a
return value from the function, but it strikes me that, all else being
equal, a return value of point could be more useful than nothing…

  reply	other threads:[~2011-07-01  0:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-08 22:47 [PATCH] org-end-of-meta-data-and-drawers Eric Abrahamsen
2011-06-09  0:34 ` Eric Abrahamsen
2011-06-09  0:43   ` Eric Abrahamsen
2011-06-29 15:52     ` Eric Abrahamsen
2011-06-30 16:03       ` Bastien
2011-06-30 16:02 ` Bastien
2011-07-01  0:46   ` Eric Abrahamsen [this message]
2011-07-05  9:05     ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ei2alteb.fsf@ericabrahamsen.net \
    --to=eric@ericabrahamsen.net \
    --cc=emacs-orgmode@gnu.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).