emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Org errors while building agenda: (void-function org-hh:mm-string-to-minutes)
@ 2011-08-19 15:39 Tassilo Horn
  2011-08-19 20:12 ` Bastien
  0 siblings, 1 reply; 3+ messages in thread
From: Tassilo Horn @ 2011-08-19 15:39 UTC (permalink / raw)
  To: emacs-orgmode

Hi,

it seems commit

commit 8c3ecbe39a0c99e3724246d1eb460495a53721b6
Author: Bastien Guerry <bzg@altern.org>
Date:   Wed Aug 17 16:08:02 2011 +0200

    Move three functions and add appropriate require/declarations.
    
    * org-clock.el (org-duration-string-to-minutes)
    (org-minutes-to-hh:mm-string, org-hh:mm-string-to-minutes):
    Move from org.el.

has broken my agenda.  I get

Debugger entered--Lisp error: (void-function org-hh:mm-string-to-minutes)
  org-hh:mm-string-to-minutes("16:30")
  org-format-agenda-item(...)

because that function has been moved to org-clock.el, which I don't
use.  If I require that, the agenda works again.

org-agenda.el contains `declare-function' statements for the three moved
functions to silence the byte compiler, but it does not require
org-clock in `org-format-agenda-item' nor do the three functions have
autoload cookies.

BTW: What's the original intention of the move?  I don't see why those
functions are specific to org-clock...

Bye,
Tassilo

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Org errors while building agenda: (void-function org-hh:mm-string-to-minutes)
  2011-08-19 15:39 Org errors while building agenda: (void-function org-hh:mm-string-to-minutes) Tassilo Horn
@ 2011-08-19 20:12 ` Bastien
  2011-08-21 19:06   ` Tassilo Horn
  0 siblings, 1 reply; 3+ messages in thread
From: Bastien @ 2011-08-19 20:12 UTC (permalink / raw)
  To: Tassilo Horn; +Cc: emacs-orgmode

Hi Tassilo,

Tassilo Horn <tassilo@member.fsf.org> writes:

> it seems commit
>
> commit 8c3ecbe39a0c99e3724246d1eb460495a53721b6
> Author: Bastien Guerry <bzg@altern.org>
> Date:   Wed Aug 17 16:08:02 2011 +0200
>
>     Move three functions and add appropriate require/declarations.
>     
>     * org-clock.el (org-duration-string-to-minutes)
>     (org-minutes-to-hh:mm-string, org-hh:mm-string-to-minutes):
>     Move from org.el.
>
> has broken my agenda.

I've reverted this commit.

I first thought `org-duration-string-to-minutes' and associated
variables and functions would better fit into org-clock.el, but
I now see they are of more general purpose.

Thanks for reporting this!

-- 
 Bastien

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Org errors while building agenda: (void-function org-hh:mm-string-to-minutes)
  2011-08-19 20:12 ` Bastien
@ 2011-08-21 19:06   ` Tassilo Horn
  0 siblings, 0 replies; 3+ messages in thread
From: Tassilo Horn @ 2011-08-21 19:06 UTC (permalink / raw)
  To: emacs-orgmode

Bastien <bzg@altern.org> writes:

Hi Bastien,

>> commit 8c3ecbe39a0c99e3724246d1eb460495a53721b6
>> Author: Bastien Guerry <bzg@altern.org>
>> Date:   Wed Aug 17 16:08:02 2011 +0200
>>
>>     Move three functions and add appropriate require/declarations.
>>     
>>     * org-clock.el (org-duration-string-to-minutes)
>>     (org-minutes-to-hh:mm-string, org-hh:mm-string-to-minutes):
>>     Move from org.el.
>>
>> has broken my agenda.
>
> I've reverted this commit.
>
> I first thought `org-duration-string-to-minutes' and associated
> variables and functions would better fit into org-clock.el, but I now
> see they are of more general purpose.

Thanks a lot!
Tassilo

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-08-21 19:06 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-19 15:39 Org errors while building agenda: (void-function org-hh:mm-string-to-minutes) Tassilo Horn
2011-08-19 20:12 ` Bastien
2011-08-21 19:06   ` Tassilo Horn

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).