From mboxrd@z Thu Jan 1 00:00:00 1970 From: Karl Fogel Subject: [PATCH] org-agenda-list (from git) giving "args-out-of-range error" Date: Wed, 29 Feb 2012 13:12:32 -0600 Message-ID: <87ehtd78tb.fsf_-_@floss.red-bean.com> References: <87vcmq1ui3.fsf@floss.red-bean.com> <8636.1330468554@alphaville> Reply-To: Karl Fogel Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([208.118.235.92]:40183) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2ox8-0005hE-MY for emacs-orgmode@gnu.org; Wed, 29 Feb 2012 14:12:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S2ox6-0008Jx-BK for emacs-orgmode@gnu.org; Wed, 29 Feb 2012 14:12:42 -0500 Received: from mail-gx0-f169.google.com ([209.85.161.169]:56965) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2ox6-0008JO-4F for emacs-orgmode@gnu.org; Wed, 29 Feb 2012 14:12:40 -0500 Received: by ggnf1 with SMTP id f1so3921711ggn.0 for ; Wed, 29 Feb 2012 11:12:38 -0800 (PST) In-Reply-To: <8636.1330468554@alphaville> (Nick Dokos's message of "Tue, 28 Feb 2012 17:35:54 -0500") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: nicholas.dokos@hp.com Cc: emacs-orgmode@gnu.org --=-=-= Content-Type: text/plain Nick Dokos writes: >There have been a couple of recent reports on this problem (headlines >with just a timestamp cause this error) in addition to the ones you >found: > > http://thread.gmane.org/gmane.emacs.orgmode/52621 > http://thread.gmane.org/gmane.emacs.orgmode/52786 > >The first one contains a diagnosis and a (possibly wrong) suggested fix. Thank you, Nick. I eventually found the same cause, by doing a binary-search reduction of the problematic .org file until I knew exactly which headline was the source of the problem. It was a second-level headline with a date but no content... ** <2012-02-27 Mon> ...as described in James Atwood's mail (the second one you list above). It's relevant that the line ends immediately after the ">". If there is even one space after the ">", then the bug does not reproduce. This makes sense, given the code. I have a tentative patch, which is attached. What's the typical way to submit such things for review? --=-=-= Content-Type: text/plain Content-Disposition: inline; filename=agenda-date-only-heading-bug-patch.txt Content-Description: Tentative fix for bug whereby a heading that is empty except for a datestamp causes an args-out-of-range error when an agenda is being generated. >From 8a4c65479b2f62cbffe32735c4afac5dd6a1ecae Mon Sep 17 00:00:00 2001 From: Karl Fogel Date: Wed, 29 Feb 2012 13:06:06 -0600 Subject: [PATCH] * lisp/org-agenda.el (org-agenda-highlight-todo): Handle the case of a heading that has a date but no todo keyword. This is a fix for the args-out-of-range bug discussed in these threads http://thread.gmane.org/gmane.emacs.orgmode/52621 http://thread.gmane.org/gmane.emacs.orgmode/52793 http://thread.gmane.org/gmane.emacs.orgmode/52786 http://thread.gmane.org/gmane.emacs.orgmode/52810 among Ilya Shlyakhter, James Atwood, Nick Dokos, and myself. The subject headers are: bug report: agenda timeline crashes Bug report: weekly agenda and blank, timestamped headers org-agenda-list (from git) giving "args-out-of-range error" --- lisp/org-agenda.el | 12 +++++++++++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el index 98a2cc0..ac1b5b1 100644 --- a/lisp/org-agenda.el +++ b/lisp/org-agenda.el @@ -5889,8 +5889,18 @@ could bind the variable in the options section of a custom command.") (let ((pl (text-property-any 0 (length x) 'org-heading t x))) (setq re (get-text-property 0 'org-todo-regexp x)) (when (and re + ;; Test `pl' because if there's no heading content, + ;; there's no point matching to highlight. Note + ;; that if we didn't test `pl' first, and there + ;; happened to be no keyword from `org-todo-regexp' + ;; on this heading line, then the `equal' comparison + ;; afterwards would spuriously succeed in the case + ;; where `pl' is nil -- causing an args-out-of-range + ;; error when we try to add text properties to text + ;; that isn't there. + pl (equal (string-match (concat "\\(\\.*\\)" re "\\( +\\)") - x (or pl 0)) pl)) + x pl) pl)) (add-text-properties (or (match-end 1) (match-end 0)) (match-end 0) (list 'face (org-get-todo-face (match-string 2 x))) -- 1.7.9 --=-=-=--