emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <n.goaziou@gmail.com>
To: Robert Klein <kleinrob@mpip-mainz.mpg.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: Publishing using the new exporter
Date: Tue, 25 Sep 2012 12:58:12 +0200	[thread overview]
Message-ID: <87ehlq9xob.fsf@gmail.com> (raw)
In-Reply-To: <50615A38.2020506@mpip-mainz.mpg.de> (Robert Klein's message of "Tue, 25 Sep 2012 09:16:08 +0200")

Hello,

Robert Klein <kleinrob@mpip-mainz.mpg.de> writes:

> If i set :html-preable to either s2-preamble or 's2-preamble nothing 
> gets inserted.
>
> I studied the code in org-e-html (excerpt below), but i don't see what I 
> did wrong.
>
> #+begin_src elisp :file contrib/lisp/org-e-html.el :firstline 1329
> (defun org-e-html-preamble (info)
>    (when (plist-get info :html-preamble)
>      (let* ((title (org-export-data (plist-get info :title) info))
> 	   (date (org-e-html-format-date info))
> 	   (author (org-export-data (plist-get info :author) info))
> 	   (email (plist-get info :email))
> 	   (html-pre-real-contents
> 	    (cond
> 	     ((functionp (plist-get info :html-preamble))
> 	      (with-temp-buffer
> 		(funcall (plist-get info :html-preamble))
> 		(buffer-string)))
> #+end_src

That's because the code expects the function to write to a buffer
instead of simply returning a string, which is wrong IMO.

The condition should simply be:

  ((functionp (plist-get info :html-preamble))
   (funcall (plist-get info :html-preamble)))

I will change this in a few hours unless someone beats me to it.


Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2012-09-25 11:02 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-24  9:57 Publishing using the new exporter Robert Klein
2012-09-24 10:25 ` Nicolas Goaziou
2012-09-24 15:57   ` Nick Dokos
2012-09-24 17:25     ` Achim Gratz
2012-09-24 17:27   ` Robert Klein
2012-09-25  7:16     ` Robert Klein
2012-09-25 10:58       ` Nicolas Goaziou [this message]
2012-09-25 20:54       ` Nicolas Goaziou
2012-10-06 11:17     ` Nicolas Goaziou
2012-10-06 14:52       ` Robert Klein
2012-10-06 17:48         ` Nicolas Goaziou
2012-10-07 13:21           ` Robert Klein
2012-10-08 12:55             ` Nicolas Goaziou
2012-10-08 16:05               ` Robert Klein
2012-10-08 16:49                 ` Nicolas Goaziou
2012-10-08 17:36                   ` Robert Klein
2012-10-08 17:46                     ` Suvayu Ali
2012-10-09  5:06                       ` Robert Klein
2012-10-09 10:07                     ` Robert Klein
2012-10-10 16:59                       ` Nicolas Goaziou
2012-10-10 19:15                         ` Robert Klein
2012-10-11 21:55                           ` Nicolas Goaziou
2012-10-15  9:35                             ` Robert Klein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ehlq9xob.fsf@gmail.com \
    --to=n.goaziou@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=kleinrob@mpip-mainz.mpg.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).