From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bastien <bzg@altern.org>
Subject: Re: bug#12905: 24.2.50; org: edit source block causes data loss
Date: Fri, 14 Dec 2012 10:38:11 +0100
Message-ID: <87ehit55z0.fsf@bzg.ath.cx>
References: <50A62865.8010904@gmail.com>
	<87sj7han8a.fsf__16482.9143243425$1354894646$gmane$org@gnu.org>
	<87wqwnyzud.fsf__32428.3239235685$1355331429$gmane$org@bzg.ath.cx>
	<87bodzt201.fsf@norang.ca> <877gom7tc3.fsf@bzg.ath.cx>
	<876246skbt.fsf@norang.ca> <87lid262rf.fsf@norang.ca>
	<8738za44ss.fsf@bzg.ath.cx> <878v925aru.fsf@norang.ca>
	<CAM=K+iqz+xCtX1=VKbdAyfFvuj3JPEP=oqnAoY-0U0Kqo6XDag@mail.gmail.com>
	<87wqwm0yoi.fsf@bzg.ath.cx>
	<CAM=K+iq=x557g5VeUFRr4_ZdHznD=KTNGsy1O0JuCGrLZT8eRw@mail.gmail.com>
	<87mwxhyl5l.fsf@bzg.ath.cx>
	<CAM=K+ioHiom-PNz5fV83MtA6JY1pVLG8a8YUvi08MiSUvZbyXw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:53799)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1TjRig-0002WI-VB
	for emacs-orgmode@gnu.org; Fri, 14 Dec 2012 04:38:16 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1TjRie-0003Qz-Qh
	for emacs-orgmode@gnu.org; Fri, 14 Dec 2012 04:38:14 -0500
Received: from mail-wg0-f51.google.com ([74.125.82.51]:56755)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1TjRie-0003Qq-KY
	for emacs-orgmode@gnu.org; Fri, 14 Dec 2012 04:38:12 -0500
Received: by mail-wg0-f51.google.com with SMTP id gg4so1282547wgb.30
	for <emacs-orgmode@gnu.org>; Fri, 14 Dec 2012 01:38:11 -0800 (PST)
In-Reply-To: <CAM=K+ioHiom-PNz5fV83MtA6JY1pVLG8a8YUvi08MiSUvZbyXw@mail.gmail.com>
	(Le Wang's message of "Fri, 14 Dec 2012 07:40:15 +0800")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Le Wang <l26wang@gmail.com>
Cc: Bernt Hansen <bernt@norang.ca>, emacs-orgmode@gnu.org

Hi Le,

Le Wang <l26wang@gmail.com> writes:

> If I press C-' before on a line BEFORE "+begin_src ...", then doing
> comparison with ">=" with beg==nil and end==nil causes
> "wrong-type-argument" error.

I think the check should happen before, see how I did it here:
http://orgmode.org/cgit.cgi/org-mode.git/commit/?id=81d5eb

> "test-org-src/point-outside-block" test case should fail, but because
> "wrong-type-argument" is also an error, it is passing.  :(
>
> I've changed "(error ..." to raise an org-src specific error to
> facilitate testing.  Commits rebased to master are attached.

Using signal makes sense if our testing suite uses it, yes.
Can you merge your patches and provide a ChangeLog when the
change affects org-src.el (and possibly test-org-src.el too)?  

Thanks a lot!

-- 
 Bastien