From: Ian Kelling <ian@iankelling.org>
To: Achim Gratz <Stromeko@nexgo.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fix error prone babel table output format detection
Date: Thu, 01 May 2014 01:30:10 -0700 [thread overview]
Message-ID: <87eh0dnbot.fsf@treetowl.lan> (raw)
In-Reply-To: <8761lqrn5p.fsf@Rainer.invalid> (Achim Gratz's message of "Thu, 01 May 2014 09:08:50 +0200")
Achim Gratz <Stromeko@nexgo.de> writes:
> Ian Kelling writes:
>> org-babel table output uses different formatting for a list of lists,
>> but detects it incorrectly causing an error, as in this example:
>> #+begin_src emacs-lisp
>> '((1) 2)
>> #+end_src
>
> So this isn't a proper table, what do you expect to happen?
I expect to be able to emacs -q, make an org mode buffer containing
that block, do ctrl-c c on it, and not have an error message pop up and
fail to have any output. What is improper about it? Would it be better
if org did not try to format it as a table?
>
>> - (and (listp (car result))
>> - (listp (cdr (car result)))))
>> + (cl-every 'listp result))
>
> This is wrong, because a table can come with any number of 'hline
> symbols, so ostensibly not every element will be a listp.
Yes, I agree. It will have to test if elements are listp or hline.
> Besides, you
> can't use cl-every unless Org drops backwards compatibility with older
> Emacsen or mandates cl-lib to be present. Even then, you'd also need to
> require cl-extra.
I forgot about the multiple parts of cl. I originally wrote it without,
and can change it.
next prev parent reply other threads:[~2014-05-01 8:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-01 4:56 [PATCH] Fix error prone babel table output format detection Ian Kelling
2014-05-01 7:08 ` Achim Gratz
2014-05-01 8:30 ` Ian Kelling [this message]
2014-05-01 9:13 ` Ian Kelling
2014-05-01 9:32 ` Ian Kelling
2014-05-01 9:55 ` Ian Kelling
2014-05-04 15:51 ` Eric Schulte
2014-05-04 19:42 ` Ian Kelling
2014-05-07 9:15 ` Eric Schulte
2014-05-07 20:57 ` Ian Kelling
2014-05-21 13:05 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eh0dnbot.fsf@treetowl.lan \
--to=ian@iankelling.org \
--cc=Stromeko@nexgo.de \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).