From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Abrahamsen Subject: Re: [RFC] Display most recent log item in Agenda Date: Mon, 15 Dec 2014 12:29:45 +0800 Message-ID: <87egs1sfgm.fsf@ericabrahamsen.net> References: <87388imto5.fsf@ericabrahamsen.net> <878uia6kdh.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:45737) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0Ot8-0002i1-SY for emacs-orgmode@gnu.org; Mon, 15 Dec 2014 01:12:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y0Ot3-0001no-EJ for emacs-orgmode@gnu.org; Mon, 15 Dec 2014 01:12:10 -0500 Received: from plane.gmane.org ([80.91.229.3]:55211) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0Ot3-0001ni-6t for emacs-orgmode@gnu.org; Mon, 15 Dec 2014 01:12:05 -0500 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1Y0Ot2-0002Yt-5T for emacs-orgmode@gnu.org; Mon, 15 Dec 2014 07:12:04 +0100 Received: from 114.248.5.200 ([114.248.5.200]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 15 Dec 2014 07:12:04 +0100 Received: from eric by 114.248.5.200 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 15 Dec 2014 07:12:04 +0100 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Nicolas Goaziou writes: > Hello, > > Eric Abrahamsen writes: > >> Undeterred by my previous bum patch, I'm sending more patches! >> >> Most of these are "what do you think" patches. >> >> 1. Ensure-org-log-into-drawer-returns-nil-or-string >> >> If the answer to my last question is "make sure `org-log-into-drawer' >> never returns just t", then this patch does that. If that isn't the >> answer, something can be done with `org-log-beginning'. > > I applied something similar. Thank you. I think this still isn't quite right. If the variable `org-log-into-drawer' is set to t, and the entry has no logdrawer property, the whole function still returns the t, which breaks `org-log-beginning'. >> 2. Missing-comma-in-org-agenda-with-point-at-orig-entry >> >> The (currently unused) macro `org-agenda-with-point-at-orig-entry' is >> missing a comma. >> >> 3. New-function-org-get-log-list and >> New-function-org-agenda-show-log-item >> >> This is the "what do you think part". The first patch finds and returns >> the state log items of the current entry, as a list of parsed elements. >> It probably doesn't try hard enough to make sure it's really found the >> list. >> >> The second implements an Agenda command which displays the text of the >> most recent note on the entry under point. I use logging a lot, and am >> forever looking at "WAIT" or "NEXT" todos, and wondering what the heck I >> was waiting for, or actually supposed to do next. >> >> If this is acceptable in principle, the finished product would probably >> be a normal org-mode function, with an Agenda implementation on top of >> that, and maybe some sort of guard against displaying overly-long >> notes. > > [...] > >> WDYT? > > I think the feature is interesting. However, the implementation seems > inefficient. Why do you need to parse all log entries if all you're > interested in is the last one? Parsing the last one should be > sufficient. > > Better, you could store the last note as a text property on the headline > and skip altogether the parsing phase. > > WDYT? > > > Regards,