From mboxrd@z Thu Jan 1 00:00:00 1970 From: Phil Hudson Subject: [PATCH] org-agenda.el: Fix `org-agenda-bulk-custom-functions' supported Customize type Date: Wed, 11 May 2016 16:02:13 +0100 Message-ID: <87eg98fxje.fsf@quiz.hudson-it.ddns.net> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:52677) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0VdB-0005HA-Vh for emacs-orgmode@gnu.org; Wed, 11 May 2016 11:01:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b0Vd7-0008M7-DS for emacs-orgmode@gnu.org; Wed, 11 May 2016 11:00:57 -0400 Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]:35081) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0Vd7-0008LD-66 for emacs-orgmode@gnu.org; Wed, 11 May 2016 11:00:53 -0400 Received: by mail-wm0-x241.google.com with SMTP id e201so9989914wme.2 for ; Wed, 11 May 2016 08:00:52 -0700 (PDT) Received: from quiz.hudson-it.ddns.net.quiz.hudson-it.ddns.net (82-71-5-38.dsl.in-addr.zen.co.uk. [82.71.5.38]) by smtp.gmail.com with ESMTPSA id x124sm8936493wmg.24.2016.05.11.08.00.49 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 May 2016 08:00:51 -0700 (PDT) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: emacs-orgmode@gnu.org Hope this is all correct now. If it is, I'll do the next, somewhat bigger patch tomorrow. If not, please feed back on what I need to do differently. Just to reiterate: I have signed the FSF papers, so I didn't include the cookie about the change being tiny, which I read the instructions as saying only applies if you haven't signed the papers. Here's the git format-patch output: >From 256cf1f854e902de392a325ec4b9c8204fb84a21 Mon Sep 17 00:00:00 2001 From: Phil Hudson Date: Wed, 11 May 2016 15:34:12 +0100 Subject: [PATCH] org-agenda.el: Fix `org-agenda-bulk-custom-functions' supported Customize type * org-agenda.el (`org-agenda-bulk-custom-functions'): Change the defcustom template to recognize that the code expects this alist's elements to be two-element lists like (?a b), not conses like (?a . b). The Customize UI previously incorrectly presented the latter. When saved, this led to the agenda bulk-commands menu correctly presenting the accelerator key 'a' but then erroring when it tried to execute the associated command 'b'. --- lisp/org-agenda.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el index ef41678..ab280fb 100644 --- a/lisp/org-agenda.el +++ b/lisp/org-agenda.el @@ -2008,7 +2008,7 @@ For example, this value makes those two functions available: With selected entries in an agenda buffer, `B R' will call the custom function `set-category' on the selected entries. Note that functions in this alist don't need to be quoted." - :type 'alist + :type '(alist :key-type character :value-type (group function)) :version "24.1" :group 'org-agenda) -- 2.8.0.rc3 -- Phil Hudson http://hudson-it.ddns.net @UWascalWabbit PGP/GnuPG ID: 0x887DCA63