From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [Patch v2] Add support for sqsh sql src blocks
Date: Sat, 03 Dec 2016 09:08:01 +0100
Message-ID: <87eg1pcu5a.fsf@nicolasgoaziou.fr>
References: <87vavdkmes.fsf@ArchNemesis.i-did-not-set--mail-host-address--so-tickle-me>
	<87a8cjfe4c.fsf@nicolasgoaziou.fr>
	<87vav5zsfm.fsf@ArchNemesis.i-did-not-set--mail-host-address--so-tickle-me>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55004)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1cD5Ma-0003zz-6O
	for emacs-orgmode@gnu.org; Sat, 03 Dec 2016 03:08:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1cD5MV-0006ro-DP
	for emacs-orgmode@gnu.org; Sat, 03 Dec 2016 03:08:04 -0500
Received: from relay4-d.mail.gandi.net ([217.70.183.196]:36700)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
	id 1cD5MV-0006rc-7J
	for emacs-orgmode@gnu.org; Sat, 03 Dec 2016 03:07:59 -0500
In-Reply-To: <87vav5zsfm.fsf@ArchNemesis.i-did-not-set--mail-host-address--so-tickle-me>
	(madhat2r@dukefoo.com's message of "Tue, 29 Nov 2016 19:07:25 -0600")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: MaDhAt2r <madhat2r@dukefoo.com>
Cc: emacs-orgmode@gnu.org

Hello,

MaDhAt2r <madhat2r@dukefoo.com> writes:

> Thanks for your comments Nicolas! I hope this is better.

Thank you. This looks good.

However, I'm not able to apply it on master branch. Could you rebase
your branch against master and send that patch again?

Also, could you provide an ORG-NEWS entry about the new feature?

> +(defun org-babel-sql-dbstring-sqsh (host user password database)
> +  "Make sqlcmd commmand line args for database connection.
> +`sqsh' is one method to access Sybase or MS SQL via Linux platform"

`sqsh' -> "sqsh"

> +  (cond
> +	 ((equal (intern engine) 'sqsh)
> +    (org-table-import out-file '(4))
> +    )

The lonesome parenthesis should go to the line above it.


Regards,

-- 
Nicolas Goaziou