From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Carlos Pita <carlosjosepita@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug: Latex preview fg color w/tikz (known problem, fix suggested) [9.1.9 (release_9.1.9-65-g5e4542 @ /home/carlos/local/stow/emacs-26/share/emacs/26.1.90/lisp/org/)]
Date: Thu, 03 Jan 2019 12:35:28 +0100 [thread overview]
Message-ID: <87ef9uug73.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CAELgYhfqYsPnwn5iMcQ93LwGcE6Xm-k5qoM_Rt6hgUH-OOJrRg@mail.gmail.com> (Carlos Pita's message of "Wed, 2 Jan 2019 19:12:51 -0300")
Hello,
Carlos Pita <carlosjosepita@gmail.com> writes:
> Here is a patch. It removes quite a few LOC.
Thank you.
> Every other previewer has :use-xcolor t. I assume it's safe to simply
> ignore :use-xcolor if it's there except that some user has configured
> a converter that for some reason requires the color command line args,
> in which case he will get an error (because of the color placeholders
> left untouched in the command line template).
Could you also add an entry in ORG-NEWS, in Incompatible Changes section?
> From 9beda785e60c791bc6524b996b60e9db00f858b7 Mon Sep 17 00:00:00 2001
> From: memeplex <carlosjosepita@gmail.com>
> Date: Wed, 2 Jan 2019 19:05:26 -0300
> Subject: [PATCH] Use xcolor for all latex preview converters
You need to expound a bit the commit message. Please have a look at
other such messages for examples.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2019-01-03 11:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 19:17 Bug: Latex preview fg color w/tikz (known problem, fix suggested) [9.1.9 (release_9.1.9-65-g5e4542 @ /home/carlos/local/stow/emacs-26/share/emacs/26.1.90/lisp/org/)] Carlos Pita
2018-12-05 19:37 ` Carlos Pita
2018-12-05 23:38 ` Nicolas Goaziou
2018-12-08 4:32 ` Carlos Pita
2018-12-08 9:56 ` Nicolas Goaziou
2018-12-08 14:43 ` Eric S Fraga
2018-12-22 14:00 ` Carlos Pita
2019-01-01 18:08 ` Carlos Pita
2019-01-02 15:07 ` Nicolas Goaziou
2019-01-02 22:12 ` Carlos Pita
2019-01-03 11:35 ` Nicolas Goaziou [this message]
2019-01-03 15:38 ` Carlos Pita
2019-01-04 13:21 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ef9uug73.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=carlosjosepita@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).