From: Adam Porter <adam@alphapapa.net>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Respect buffer-local value of `org-edit-src-content-indentation'
Date: Tue, 15 Oct 2019 19:50:49 -0500 [thread overview]
Message-ID: <87eezdv7h2.fsf@alphapapa.net> (raw)
In-Reply-To: 87eezelxbq.fsf@gmail.com
Hi Sebastian,
Sebastian Miele <sebastian.miele@gmail.com> writes:
> * lisp/org-src.el (org-src--contents-for-write-back): Use the
> potentially buffer-local value of `org-edit-src-content-indentation'
> from the source buffer instead of that from the editing buffer.
> ---
> lisp/org-src.el | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lisp/org-src.el b/lisp/org-src.el
> index 9134d5b5d..b7fe4c0fa 100644
> --- a/lisp/org-src.el
> +++ b/lisp/org-src.el
> @@ -422,7 +422,8 @@ Assume point is in the corresponding edit buffer."
> (if org-src--preserve-indentation 0
> (+ (or org-src--block-indentation 0)
> (if (memq org-src--source-type '(example-block src-block))
> - org-edit-src-content-indentation
> + (with-current-buffer (marker-buffer org-src--beg-marker)
> + org-edit-src-content-indentation)
> 0))))
> (use-tabs? (and (> org-src--tab-width 0) t))
> (source-tab-width org-src--tab-width)
You might consider using the function buffer-local-value instead of the
macro with-current-buffer. Not that it matters so much here, but
benchmarking shows that it is much faster when simply accessing the
buffer-local value of a variable.
next prev parent reply other threads:[~2019-10-16 1:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 23:30 [PATCH] Respect buffer-local value of `org-edit-src-content-indentation' Sebastian Miele
2019-10-16 0:50 ` Adam Porter [this message]
2019-10-17 0:34 ` Sebastian Miele
2019-11-03 21:24 ` Nicolas Goaziou
2019-11-03 22:25 ` Sebastian Miele
2019-11-19 10:39 ` Nicolas Goaziou
2019-11-20 6:12 ` Sebastian Miele
2019-11-20 21:30 ` Nicolas Goaziou
2020-02-12 17:51 ` Bastien
2020-02-12 18:35 ` Sebastian Miele
2020-02-12 19:10 ` Bastien
2020-02-12 19:28 ` Sebastian Miele
2020-02-13 19:31 ` Sebastian Miele
2020-02-14 10:02 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eezdv7h2.fsf@alphapapa.net \
--to=adam@alphapapa.net \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).