From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roland Everaert Subject: Re: [PATCH] Skip entries with no ID when updating ID locations Date: Fri, 21 Feb 2020 11:31:09 +0100 Message-ID: <87eeuoz0ya.fsf@gmail.com> References: <87r1yqb75d.fsf@ericabrahamsen.net> <878sky5kd4.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:48365) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j55af-00031A-1S for emacs-orgmode@gnu.org; Fri, 21 Feb 2020 05:31:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j55ae-000793-12 for emacs-orgmode@gnu.org; Fri, 21 Feb 2020 05:31:24 -0500 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]:44037) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j55ad-00077J-PH for emacs-orgmode@gnu.org; Fri, 21 Feb 2020 05:31:23 -0500 Received: by mail-wr1-x443.google.com with SMTP id m16so1385050wrx.11 for ; Fri, 21 Feb 2020 02:31:23 -0800 (PST) In-reply-to: <878sky5kd4.fsf@gnu.org> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org Sender: "Emacs-orgmode" To: emacs-orgmode@gnu.org Cc: Eric Abrahamsen A note related to duplicate IDs, the messages only shows one of the duplicate, so it is not easy to know which one to change. This have implication when creating links to headline using their IDs. And does the current algorithm for finding duplicates check their reference through the "org db"? Regards, Roland. Bastien writes: > Hi Eric, > > Eric Abrahamsen writes: > >> Would the attached patch be acceptable? It's no big deal, just skips >> entries with no ID property when updating all ID locations. I couldn't >> figure out why I had several thousand "Duplicate ID "nil"" warnings in >> the *Messages* buffer after updating ID locations. > > A welcome enhancement - applied, thanks! -- Luke, use the FOSS Sent from Emacs