From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id DldELmpIlV5yGAAA0tVLHw (envelope-from ) for ; Tue, 14 Apr 2020 05:21:46 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id QKsXG21IlV5fOwAAB5/wlQ (envelope-from ) for ; Tue, 14 Apr 2020 05:21:49 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8008E9416B4 for ; Tue, 14 Apr 2020 05:21:47 +0000 (UTC) Received: from localhost ([::1]:52754 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOE13-0002L0-0W for larch@yhetil.org; Tue, 14 Apr 2020 01:21:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33229) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOE0g-0002Km-Aw for emacs-orgmode@gnu.org; Tue, 14 Apr 2020 01:21:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jOE0f-0005I6-6J for emacs-orgmode@gnu.org; Tue, 14 Apr 2020 01:21:22 -0400 Received: from [183.249.128.92] (port=9624 helo=dark.localdomain) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jOE0e-0005Gu-QY for emacs-orgmode@gnu.org; Tue, 14 Apr 2020 01:21:21 -0400 Received: by dark.localdomain (Postfix, from userid 1000) id E568C2420F8; Tue, 14 Apr 2020 13:21:12 +0800 (HKT) References: <87ftdact0g.fsf@gmail.com> <87eesu2ekz.fsf@nicolasgoaziou.fr> <87d08c9i7j.fsf@gmail.com> <87ftd7agwl.fsf@localhost> <877dyj9wkc.fsf@gmail.com> <87k12j491l.fsf@localhost> <87wo6jw3yi.fsf@nicolasgoaziou.fr> User-agent: mu4e 1.3.8; emacs 28.0.50 From: stardiviner To: Nicolas Goaziou Subject: Re: [SOLVED] Re: [PATCH] Show hidden drawers when org-cycle on headlines In-reply-to: <87wo6jw3yi.fsf@nicolasgoaziou.fr> Date: Tue, 14 Apr 2020 13:21:12 +0800 Message-ID: <87eesqmylz.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 183.249.128.92 X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: numbchild@gmail.com Cc: emacs-orgmode@gnu.org, Ihor Radchenko Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 X-Spam-Score: 1.59 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Scan-Result: default: False [1.59 / 13.00]; HAS_REPLYTO(0.00)[numbchild@gmail.com]; GENERIC_REPUTATION(0.00)[-0.57631876125444]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.51.188.0/24:c]; FREEMAIL_FROM(0.00)[gmail.com]; REPLYTO_ADDR_EQ_FROM(0.00)[]; R_MISSING_CHARSET(2.50)[]; IP_REPUTATION_HAM(0.00)[asn: 22989(0.28), country: US(-0.01), ip: 209.51.188.17(-0.58)]; MX_GOOD(-0.50)[cached: eggs.gnu.org]; MAILLIST(-0.20)[mailman]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; RCVD_TLS_LAST(0.00)[]; R_DKIM_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; TAGGED_FROM(0.00)[larch=yhetil.org]; ASN(0.00)[asn:22989, ipnet:209.51.188.0/24, country:US]; ARC_NA(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; FROM_NEQ_ENVFROM(0.00)[numbchild@gmail.com,emacs-orgmode-bounces@gnu.org]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; MIME_GOOD(-0.10)[text/plain]; FREEMAIL_REPLYTO(0.00)[gmail.com]; HAS_LIST_UNSUB(-0.01)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_CC(0.00)[gnu.org,gmail.com]; FORGED_SENDER_MAILLIST(0.00)[]; DMARC_POLICY_SOFTFAIL(0.10)[gmail.com : SPF not aligned (relaxed), No valid DKIM,none] X-TUID: HyTD7Ash+kUK =2D----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Nicolas Goaziou writes: > Hello, > > Ihor Radchenko writes: > >>> Thanks Ihor, I indeed found related code in Org Mode source. I implemen= ted a >>> similar functionality in my patch. >> >> Oh. I somehow missed your first message... >> >> Now, actually adding something to the discussion. >> >> FYI, there is org-cycle-include-plain-lists variable. If it is set to >> 'integrate, plain lists will be included into cycling with point at >> headline. This is against the logic that org-cycle only needs to be >> dealing with headlines. So, I don't see your patch breaking the present >> conventions in org. > > Yes, this `integrate' value is not great, IMO. However, plain lists have > much more in common with headlines than with drawers. > > I still think basic cycling should not include drawers whatsoever. This > is even more true for properties drawers. > > Note that you can already display drawers with `org-cycle', using three > prefix arguments. I agree. As I described in my given example "org-contacts", which include p= erson info in properties drawer. That's why I want to expand when I press "Tab" on expanding headline. If I see a contact's info with "C-u C-u C-u Tab" is not convenient. As for this negation, I can accept. Is it possible to change "org-cycle-hide-drawers" to "org-cycle-toggle-draw= ers". Make it more extendable. Because that function only changed one argument of "org-flag-drawer". If so some user like me will be easy to toggle hide/show drawers. (Of course, I don't want to add redundant code in my Emacs init.) = If this is fine, I will re-edit my patch. Remove defcustom option, and hook on cycle. Only keep changes in "org-cycle-hide-drawers". =2D --=20 [ stardiviner ] I try to make every word tell the meaning what I want to express. Blog: https://stardiviner.github.io/ IRC(freenode): stardiviner, Matrix: stardiviner GPG: F09F650D7D674819892591401B5DF1C95AE89AC3 =20=20=20=20=20=20 =2D----BEGIN PGP SIGNATURE----- iQFIBAEBCAAyFiEE8J9lDX1nSBmJJZFAG13xyVromsMFAl6VSEgUHG51bWJjaGls ZEBnbWFpbC5jb20ACgkQG13xyVromsMFWAgAlhqnLF0PByf0k2Au3v7Ge4kj+BeF U/S0XL+U3t8sjGSvXpR50AFEH9wPsp2Hr0yguJ2/WJDYDAO8dvzphcMgwP/q5EfZ 25hmKWQOP25rBMiHyXVcws6lVWLcsZ55l9k5ff/3mR2j5qV5dsA37G4gosbfTwMn a29FXHyLBxMZMZgKGfK3cDY+W7F0tZ+XO4+E6TTZzu6OD8EmUwptbkmBd5XyiomQ C7R1lBSR2xOYxFgdqy9sEp88lcRufN0tK3dun0hIotfabGq2HVv7lvsfD9DOC+IF jaJKBzVzIAfvFCJVIUksW+DKvB4CiwL/Wm3NbzRaQmM4XZ66Emn1CaPYjQ=3D=3D =3DxMZt =2D----END PGP SIGNATURE-----