emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: Mario Frasca <mario@anche.no>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] implementing `with' as a list, and respecting `deps' order.
Date: Wed, 03 Jun 2020 23:50:40 +0000	[thread overview]
Message-ID: <87eeqvwvxr.fsf@kyleam.com> (raw)
In-Reply-To: <75d44425-a3bf-f7e9-885d-8ca36e0b5205@anche.no>

Mario Frasca writes:

> comments on the html page org-contribute.html:
[...]
> the procedure mentioned there guides me in creating several patch files, 
> one per commit.  it does not describe the "squashing" you suggested me.  
> I'm following your guide, but you might want to review the page yourself.

My suggestion to you in the original thread [*] was in the context of
updating a patch you sent based on reviewer feedback.  The instructions
on the org-contribute page are in the context of sending an initial
series to the list, providing a two-patch series as an example.  These
are distinct things.

If the change you're proposing conceptually fits into several commits
(of course, how to divide things up is a subjective art), then please do
so.  As I said in the original thread:

  Just for clarity: In this case, I think the change proposed so far makes
  sense to present as a single commit.  I'm not claiming that in general a
  patch series should be reduced to _one_ commit.

I don't doubt that my descriptions or org-contribute's could be clearer.
Suggestions on how to improve the org-contribute page are of course
welcome, though I think it'd be a mistake to turn it into a Git
tutorial.


[*] https://yhetil.org/orgmode/874krvvdr3.fsf@kyleam.com/


      parent reply	other threads:[~2020-06-03 23:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-02 15:57 Mario Frasca
2020-06-03  3:38 ` Kyle Meyer
2020-06-03 14:46   ` Mario Frasca
2020-06-03 15:03     ` Bastien
2020-06-03 23:50     ` Kyle Meyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eeqvwvxr.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=mario@anche.no \
    --subject='Re: [PATCH] implementing `with'\'' as a list, and respecting `deps'\'' order.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).