From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 0E7GH0sx+F7AXgAA0tVLHw (envelope-from ) for ; Sun, 28 Jun 2020 05:57:31 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id sJOHG0sx+F7QXgAA1q6Kng (envelope-from ) for ; Sun, 28 Jun 2020 05:57:31 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E5259940655 for ; Sun, 28 Jun 2020 05:57:30 +0000 (UTC) Received: from localhost ([::1]:41404 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jpQJj-0005Yf-IB for larch@yhetil.org; Sun, 28 Jun 2020 01:57:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59746) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jpQHu-0005YV-D8 for emacs-orgmode@gnu.org; Sun, 28 Jun 2020 01:55:34 -0400 Received: from ciao.gmane.io ([159.69.161.202]:44402) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jpQHr-0001vY-5U for emacs-orgmode@gnu.org; Sun, 28 Jun 2020 01:55:34 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1jpQHn-000KCq-VN for emacs-orgmode@gnu.org; Sun, 28 Jun 2020 07:55:27 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Jarmo Hurri Subject: Re: Babel: parse error when output contains opening bracket Date: Sun, 28 Jun 2020 08:55:19 +0300 Message-ID: <87eepz3faw.fsf@iki.fi> References: <87d05nidu1.fsf@iki.fi> <87pn9l2i7z.fsf@iki.fi> Mime-Version: 1.0 Content-Type: text/plain User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Cancel-Lock: sha1:I/EHk7qfM18D1c0KHbTz/mVgUyE= Received-SPF: pass client-ip=159.69.161.202; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/28 01:55:28 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -8 X-Spam_score: -0.9 X-Spam_bar: / X-Spam_report: (-0.9 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -0.51 X-TUID: GivCJVrYUN/K >> ian martins writes: >> >> Would it be possible for us to fix the current version without >> introducing a new one? Can you identify the parts of your code that fix >> the issue? >> > The existing code creates the java program and runs it correctly, but > it uses `org-babel-import-elisp-from-file' to interpret the results, > and that sees the bracket and tries to make the response into a list, > and errors when it can't. I don't see a quick fix for it. If you allow > unbalanced brackets but that would be a change in ob-core and would > probably cause unwanted results in other places. If you don't try to > convert the output into a list, you can't present java results as > lists or tables. Really the problem is that ob-java doesn't support > functional mode, so it tries to guess if scripting mode output should > be a table or list. The version I wrote supports functional and > scripting modes and doesn't use `org-babel-import-elisp-from-file'. Ok. >> I am already a contributor, so if you can post your solution here I >> can create a patch and give you the credit. >> > I would really appreciate that if you are willing, but it's a > significant change (code is 400 lines, 600 lines of tests and test > data) and there might be iterations so you might be signing up for > more than you realize. Fair enough. 1. Have you considered writing a patch yourself? 2. If not, I think you lose nothing by posting your code here and patiently waiting if I can create something out of it. All the best, Jarmo