* doc/org-manual.org (Clocking Work Time): Replace "to that you can" with "so that you can". --- doc/org-manual.org | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/org-manual.org b/doc/org-manual.org index b14c28807..b61644626 100644 --- a/doc/org-manual.org +++ b/doc/org-manual.org @@ -6379,7 +6379,7 @@ clock. When you stop working on that task, or when you mark the task done, the clock is stopped and the corresponding time interval is recorded. It also computes the total time spent on each subtree[fn:71] of a project. And it remembers a history or tasks -recently clocked, to that you can jump quickly between a number of +recently clocked, so that you can jump quickly between a number of tasks absorbing your time. To save the clock history across Emacs sessions, use: -- 2.26.2
Hi Arun,
Thanks for the patch. I applied it.
> * doc/org-manual.org (Clocking Work Time): Replace "to that you can"
> with "so that you can".
To make the handling of patches easier please use "format-patch". More
details from the Emacs CONTRIB:
--8<---------------cut here---------------start------------->8---
To email a patch you can use a shell command like 'git format-patch -1'
to create a file, and then attach the file to your email. This nicely
packages the patch's commit message and changes, and makes sure the
format and whitespace are not munged in transit by the various mail
agents.
--8<---------------cut here---------------end--------------->8---
Thanks again,
--
Marco
Hi Marco, Marco Wahl writes: > To make the handling of patches easier please use "format-patch". It looks like this was sent with git-send-email (which is fed format-patch output either explicitly or underneath), and it applied cleanly for me. My understanding is that, even though this project accepts patches as attachments [*], inline patches are fine as well (and very much my personal preference). git-send-email is explicitly mentioned at <https://orgmode.org/worg/org-contribute.html>. [*] I believe there was a thread recently on emacs-devel that stated a preference for attachments, but I'd be sad if we as a project adopted the same stance.
[-- Attachment #1: Type: text/plain, Size: 726 bytes --] >> To make the handling of patches easier please use "format-patch". > > It looks like this was sent with git-send-email (which is fed > format-patch output either explicitly or underneath), and it applied > cleanly for me. > > My understanding is that, even though this project accepts patches as > attachments [*], inline patches are fine as well (and very much my > personal preference). git-send-email is explicitly mentioned at > <https://orgmode.org/worg/org-contribute.html>. Indeed, I used `git format-patch` to create the patch and `git send-email` to send it. I don't mind sending attachments, but I used `git send-email` since it was allowed by the contribution guidelines. Thanks for applying the fix. Cheers! [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 487 bytes --]
Hi Kyle and Arun, >> To make the handling of patches easier please use "format-patch". > > It looks like this was sent with git-send-email (which is fed > format-patch output either explicitly or underneath), and it applied > cleanly for me. Okay, good. Thanks for sharing! Apologies for demanding too much, Arun. > My understanding is that, even though this project accepts patches as > attachments [*], inline patches are fine as well (and very much my > personal preference). git-send-email is explicitly mentioned at > <https://orgmode.org/worg/org-contribute.html>. > > [*] I believe there was a thread recently on emacs-devel that stated a > preference for attachments, but I'd be sad if we as a project > adopted the same stance. Up to now I thought only a 'format-patch' can be applied easily. Would you please share a way to apply an inline patch? Or at least give a hint? Thanks and best regards, -- Marco
Marco Wahl writes: > Up to now I thought only a 'format-patch' can be applied easily. Would > you please share a way to apply an inline patch? Or at least give a hint? Sure. For an inline patch, you feed the entire message, rather than the attachment, to 'git am'. It looks like Gnus is your MUA, so you may be interested in gnus-summary-pipe-output. For those that don't use an Emacs-based mail client, something like this might be more convenient than getting the message out of your reader: $ # in org repo $ curl -fSsL https://orgmode.org/list/MSGID/raw | git am In this particular case $ curl -fSsL https://orgmode.org/list/20200705112846.16510-1-arunisaac@systemreboot.net/raw | git am
Kyle Meyer <kyle@kyleam.com> writes:
>> Up to now I thought only a 'format-patch' can be applied easily. Would
>> you please share a way to apply an inline patch? Or at least give a hint?
>
> Sure. For an inline patch, you feed the entire message, rather than the
> attachment, to 'git am'. It looks like Gnus is your MUA, so you may be
> interested in gnus-summary-pipe-output.
>
> For those that don't use an Emacs-based mail client, something like this
> might be more convenient than getting the message out of your reader:
>
> $ # in org repo
> $ curl -fSsL https://orgmode.org/list/MSGID/raw | git am
>
> In this particular case
>
> $ curl -fSsL
> https://orgmode.org/list/20200705112846.16510-1-arunisaac@systemreboot.net/raw
> | git am
Thanks Kyle!