emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: "Kévin Le Gouguec" <kevin.legouguec@gmail.com>
To: Jarmo Hurri <jarmo.hurri@iki.fi>
Cc: emacs-orgmode@gnu.org
Subject: Re: Binding RET to org-return-and-maybe-indent
Date: Fri, 24 Jul 2020 18:59:15 +0200	[thread overview]
Message-ID: <87eep0svbw.fsf@gmail.com> (raw)
In-Reply-To: <87pn8l5yja.fsf@iki.fi> (Jarmo Hurri's message of "Fri, 24 Jul 2020 07:26:17 +0300")

Jarmo Hurri <jarmo.hurri@iki.fi> writes:

> * Demo of the effect of disabling elint
>   1. Save this org into file =org-elint-disable.org=
>   2. Save the following elisp into =minimal-org.el=, replacing the
>      location of org mode with your path:
>
>      #+begin_src elisp
>        (add-to-list 'load-path (expand-file-name "~/src/org-mode/lisp"))
>        (add-to-list 'load-path (expand-file-name "~/src/org-mode/contrib/lisp" t))
>        (add-hook 'org-mode-hook (lambda () (electric-indent-mode -1)))
>      #+end_src
>
>   3. Toggle the last line
>
>      #+begin_src elisp
>      (add-hook 'org-mode-hook (lambda () (electric-indent-mode -1)))
>      #+end_src
>
>      in =minimal-org.el= to see the following effect:
>      1. Open this file with
>
>         #+begin_src sh
> 	  emacs -Q -l minimal-org.el org-elint-disable.org
>         #+end_src
>
>      2. Type C-c ' for (org-edit-special) in the source code block below,
> 	and follow the instructions on the comment line.
>
> 	#+begin_src java :exports none :classname Demo
> 	  class Demo
> 	  {
> 	      // 1st press RET at the end of this line, then type TAB and }
> 	#+end_src

OK, here are my observations:

* Emacs 28, Org 9.3
  - RET: indented
  - TAB: nothing
  - }: de-indents
* Emacs 28, Org master, electric-indent-mode on
  - RET: indented
  - TAB: nothing
  - }: de-indents
* Emacs 28, Org master, electric-indent-mode off
  - RET: not indented
  - TAB: indents
  - }: does not indent

I think this is just because disabling electric-indent-mode is the wrong
thing to do: it should be electric-indent-local-mode.  The former
changes the default value of electric-indent-mode for *all buffers*,
whereas the intent is to only disable it in Org buffers; we don't want
to affect Org Src buffers…

If I replace (electric-indent-mode -1) with (electric-indent-local-mode
-1) in org-mode-hook, I get the behaviour we have with "Org 9.3" and
"Org master, electric-indent-mode on".

Can you tell me whether electric-indent-local-mode works better for you?
If it does, I'll followup with a patch to ORG-NEWS.


  reply	other threads:[~2020-07-24 16:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-22 12:12 Jarmo Hurri
2020-07-22 14:50 ` Kévin Le Gouguec
2020-07-23  5:55   ` Jarmo Hurri
2020-07-23  9:52   ` Jarmo Hurri
2020-07-23 15:00     ` Kévin Le Gouguec
2020-07-24  4:26       ` Jarmo Hurri
2020-07-24 16:59         ` Kévin Le Gouguec [this message]
2020-07-27 10:18           ` Jarmo Hurri
2020-07-27 13:12             ` [PATCH] Fix recommendation in ORG-NEWS (was: Binding RET to org-return-and-maybe-indent) Kévin Le Gouguec
2020-07-29  1:51               ` Kyle Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eep0svbw.fsf@gmail.com \
    --to=kevin.legouguec@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=jarmo.hurri@iki.fi \
    --subject='Re: Binding RET to org-return-and-maybe-indent' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).