emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Bastien <bzg@gnu.org>
To: D <d.williams@posteo.net>
Cc: emacs-orgmode@gnu.org, Ihor Radchenko <yantar92@gmail.com>
Subject: Re: [PATCH] Re: Re: Re: org-forward-heading-same-level and the invisible-ok argument
Date: Sun, 06 Sep 2020 08:35:17 +0200	[thread overview]
Message-ID: <87eenfl8ey.fsf@bzg.fr> (raw)
In-Reply-To: 7365d467-2a31-85b4-4f0b-8c8871c4e180@posteo.net

D <d.williams@posteo.net> writes:

>> Probably, it is easier if you just use seq-every-p instead of
>> mapcar on (number-sequence max-pos min-pos -1). The result of
>> seq-every-p will be inverse of the currently used expression.
>
> Oh yeah, that's much nicer.  I also made the predicate check
> right-to-left, which just causes it to check the text bit of a heading
> first, which is useful for the cases where the predicate returns t and
> makes no difference otherwise.  I again ran the tests and it seems ready
> to go.

Thanks for the patch.  

Does it fix a problem for org-superstar-mode or a more general problem
in Org?

Why do you need to check the visibility status every character in the
headline (even for the org-superstar-mode, where you seem to need to
check for the visibility status /after/ the stars)?

If you use seq* functions, the code will be incompatible with previous
emacsen, right?

Thanks for any follow-up,

-- 
 Bastien

next prev parent reply	other threads:[~2020-09-06  6:35 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-25 16:46 org-forward-heading-same-level and the invisible-ok argument D
2020-08-26  1:30 ` Ihor Radchenko
2020-08-26 21:33   ` [PATCH] " D
2020-08-27 11:49     ` Ihor Radchenko
2020-08-28 12:27       ` [PATCH] " D
2020-08-28 13:43         ` Ihor Radchenko
2020-08-28 17:49           ` D
2020-08-29  5:10             ` Ihor Radchenko
2020-08-30 22:07               ` [PATCH] " D
2020-09-06  6:35                 ` Bastien [this message]
2020-09-06 11:09                   ` D
2020-09-07  5:06                     ` Bastien
2020-09-07  6:25                       ` Ihor Radchenko
2020-09-07 18:31                         ` D
2020-09-08  9:28                           ` Bastien
2020-09-08 20:00                             ` D
2020-09-09  8:09                               ` Bastien
2020-09-09  4:15                             ` Ihor Radchenko
2020-09-09  8:08                               ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eenfl8ey.fsf@bzg.fr \
    --to=bzg@gnu.org \
    --cc=d.williams@posteo.net \
    --cc=emacs-orgmode@gnu.org \
    --cc=yantar92@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).