From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id IMDlKnEfiGBk3QAAgWs5BA (envelope-from ) for ; Tue, 27 Apr 2021 16:28:01 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id EMKOJnEfiGCdDwAAB5/wlQ (envelope-from ) for ; Tue, 27 Apr 2021 14:28:01 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EADB9ABD0 for ; Tue, 27 Apr 2021 16:28:00 +0200 (CEST) Received: from localhost ([::1]:33416 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbOgx-0007Lg-CK for larch@yhetil.org; Tue, 27 Apr 2021 10:27:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43864) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbOel-0006Wg-SO for emacs-orgmode@gnu.org; Tue, 27 Apr 2021 10:25:44 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51411) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbOel-0001dI-Jf; Tue, 27 Apr 2021 10:25:43 -0400 Received: from [2a01:e34:ec2b:7150:6ed7:7f91:e8e8:7d37] (port=40972 helo=guerry) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.82) (envelope-from ) id 1lbOeb-0001gL-By; Tue, 27 Apr 2021 10:25:36 -0400 Received: by guerry (Postfix, from userid 1000) id 32CEE1A60E8F; Tue, 27 Apr 2021 16:25:30 +0200 (CEST) From: Bastien To: Ihor Radchenko Subject: Re: org-store-link and help for a key In-Reply-To: <87eenajoha.fsf@localhost> (Ihor Radchenko's message of "Thu, 10 Sep 2020 11:32:33 +0800") Organization: GNU References: <87eenajoha.fsf@localhost> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) X-Woof-Bug: close Date: Tue, 27 Apr 2021 16:25:30 +0200 Message-ID: <87eeevhkit.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Maxim Nikulin , emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619533681; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=35/ODblFoWSu3tqDCJ1NHZt+xfOWRns5eWxP1p2DCm0=; b=W/+Q1yQQWtf8EL9g1ubxPsDpgQg1D+Z97AnH3sCGazUW8ffqNMRDrYAkv4f1BGVoD5DvJn pirAJsFPTFbjkkmd0QcFEe3grIYxtnQ7qz5cKtwJJgeuaUjaZrigWEclcaI57rbfErDn0Z WUOvzsfui6UOWtf9G5mXf37V6rrWp4NBvT9HWZPpBXedVThfqQnL3suce9JxAuYKHYwlS4 q/ViHibfyBAjHg5YVucb115XONtEg+wa8cUVuX1troPrcFZsQErT5oLjaxkTVYTuozazLT 9+Eo+LsJewy3fSfTg0CpesMlKge87s89DQWIU7V65ylxkJ8/fFAd4r754Zyt5A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619533681; a=rsa-sha256; cv=none; b=YsQeNbp8Mme4Ilbj0CT69xEiCVAnGIj3V8BxQ2eJ1SSfSC7Mfpm00jt+C+jJ4aqKxPtA0K xkzC9Ctj07boZEdHCEqgOGnHs65MrZqCVFnuQ5ITEy2SEOqLqmnIuM0M6N/jk3T0J+0ZXH jgOL1FCkvmDZ+VUm/kd87AvFgYWsIW3FXF2Fk/blf3sRWwCssMT4kTkfq49tud8p7aw15x Gv6pUXJhtp/f5JB9h1SG5FiImbKp8LBmuq8fMkOKYJVqU4LZetqLKcK7mG77QhlRfZN446 u6ojnwmiAwRAbwi6XMdow3UZVLcj6wtrFNnVrCLLTHAp8UbLbAn8LnbMDMAoFg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -2.95 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: EADB9ABD0 X-Spam-Score: -2.95 X-Migadu-Scanner: scn0.migadu.com X-TUID: 9R+bSH5ja9Xu Hi Maxim and Ihor, Ihor Radchenko writes: >> Such behavior exists for ages, at least since 8.2.10 till current master. > > I can reproduce this. > > The reason of error is simple: help buffers for key combinations where > not considered when writing help: link type. > Current code does not even store the link to such help buffers correctly > - when the key sequence has more than a single key only the first key > will be stored (tested in k k help buffer). > The code to open help: link type also does not know that help: link can > point to anything other than function or variable. > > I can see two solutions: > > 1. Avoid storing links to help buffers describing key sequences. Show > error when trying to store such link instead Even though storing links to help buffers describing key bindings is tempting, there is no way to recreate such buffers only based on the key string, because keys are contextual. In org-mode, C-h k C-a will describe org-beginning-of-line while in other modes it will probably describe beginning-of-line. So we cannot really write a proper handler for these links and the user error is correct here. I'm closing this bug report now.