emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bastien <bzg@gnu.org>
To: Ihor Radchenko <yantar92@gmail.com>
Cc: Maxim Nikulin <manikulin@gmail.com>, emacs-orgmode@gnu.org
Subject: Re: org-store-link and help for a key
Date: Tue, 27 Apr 2021 16:25:30 +0200	[thread overview]
Message-ID: <87eeevhkit.fsf@gnu.org> (raw)
In-Reply-To: <87eenajoha.fsf@localhost> (Ihor Radchenko's message of "Thu, 10 Sep 2020 11:32:33 +0800")

Hi Maxim and Ihor,

Ihor Radchenko <yantar92@gmail.com> writes:

>> Such behavior exists for ages, at least since 8.2.10 till current master.
>
> I can reproduce this.
>
> The reason of error is simple: help buffers for key combinations where
> not considered when writing help: link type.
> Current code does not even store the link to such help buffers correctly
> - when the key sequence has more than a single key only the first key
> will be stored (tested in <f1> k <f1> k help buffer).
> The code to open help: link type also does not know that help: link can
> point to anything other than function or variable.
>
> I can see two solutions:
>
> 1. Avoid storing links to help buffers describing key sequences. Show
>    error when trying to store such link instead

Even though storing links to help buffers describing key bindings is
tempting, there is no way to recreate such buffers only based on the
key string, because keys are contextual.

In org-mode, C-h k C-a will describe org-beginning-of-line while in
other modes it will probably describe beginning-of-line.

So we cannot really write a proper handler for these links and the
user error is correct here.

I'm closing this bug report now.


  parent reply	other threads:[~2021-04-27 14:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-09 14:54 Maxim Nikulin
2020-09-10  3:32 ` Ihor Radchenko
2020-09-13 20:01   ` Bastien
2020-09-14  7:21     ` Ihor Radchenko
2021-04-27 14:25   ` Bastien [this message]
2021-04-27 14:44     ` Maxim Nikulin
2021-04-27 15:52       ` Nicolas Goaziou
2021-04-27 16:41         ` Maxim Nikulin
2021-04-27 20:01           ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eeevhkit.fsf@gnu.org \
    --to=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=manikulin@gmail.com \
    --cc=yantar92@gmail.com \
    --subject='Re: org-store-link and help for a key' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).