emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Ihor Radchenko <yantar92@gmail.com>
To: Max Mikhanosha <max.mikhanosha@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: PATCH: [PATCH] Allow bulk agenda actions to take log notes
Date: Sun, 17 Jul 2022 17:38:51 +0800	[thread overview]
Message-ID: <87edyk84es.fsf@localhost> (raw)
In-Reply-To: <CAGAC3hDA1SbciS_r+ik6O+QnnmiLA6L2MRS60KAUj6LLjR_DVg@mail.gmail.com>

Max Mikhanosha <max.mikhanosha@gmail.com> writes:

> Currently org-agenda-bulk-action is completely broken if anything tries to
> take a log note during the action, this patch fixes it by storing log note
> setup variables in a list, and then taking one log note, and duplicating it
> over all affected items.

Thanks for the patch!

I tried to test the patch and ran into an issue using the following
recipe:

1. Create /tmp/bug.org with the following contents:

#+TODO: TODO(t) | DONE(d@)
* TODO this is test
* TODO this is test
* TODO this is test
* TODO this is test
* TODO this is test
* TODO this is test
* TODO this is test
* TODO this is test

2. Open Emacs from Org git repo folder containing the patch applied onto
   the latest main branch:
   make clean; make autoloads; emacs-29-vcs -Q -L ./lisp /tmp/bug.org

3. Open agenda via M-x org-agenda <RET> < t
4. Move point to one of the TODO entries and change the toto state to
   DONE: t DONE <RET>
5. The log window will pop. Enter "something" C-c C-c
6. Mark several TODO entries in the agenda
7. Try to bulk-mark them DONE: B t DONE <RET>
8. Observe no window popup, empty notes, and some entries not
   being marked as done in the agenda buffer.

Best,
Ihor

     prev parent reply	other threads:[~2022-07-17  9:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-10 16:40 PATCH: [PATCH] Allow bulk agenda actions to take log notes Max Mikhanosha
2022-07-17  9:38 ` Ihor Radchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87edyk84es.fsf@localhost \
    --to=yantar92@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=max.mikhanosha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).