From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 0NxVIHgsQWPrsQAAbAwnHQ (envelope-from ) for ; Sat, 08 Oct 2022 09:53:28 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id oE5uIHgsQWNlRAEA9RJhRA (envelope-from ) for ; Sat, 08 Oct 2022 09:53:28 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 26B65353EE for ; Sat, 8 Oct 2022 09:53:28 +0200 (CEST) Received: from localhost ([::1]:46792 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oh4eE-0005Cz-RM for larch@yhetil.org; Sat, 08 Oct 2022 03:53:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33422) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oh4dd-0005Cp-Ei for emacs-orgmode@gnu.org; Sat, 08 Oct 2022 03:52:49 -0400 Received: from mail-pg1-x536.google.com ([2607:f8b0:4864:20::536]:36821) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oh4db-00063q-ID for emacs-orgmode@gnu.org; Sat, 08 Oct 2022 03:52:49 -0400 Received: by mail-pg1-x536.google.com with SMTP id s206so6481088pgs.3 for ; Sat, 08 Oct 2022 00:52:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=R+Ywhrt9LAznzmO9emRhAU0IYZ3ckkoMltrxTLDplTc=; b=Elo3wvaCnlI+qS9i8V2IiH76pR+KGYcukt4t8RacHma/GzZtZIwQx17hpbz9EZQ5Tm YM+LQ85VoNFcKqysDJDlYfDr5g/9vt6AD0N2IJx/XxfbhX0j2MobpEAf6dJ88dKL49bp Nry0omh9FOZZWgbWCpvTYo+NBL4KflgL6LDqmLE31Yi1EiFmlkHfSL09Gyxu0EBSrhTh 7PeQwkeX4wuZq8h6+12uVlZaObdVPocjaX2xS3a49tWPyoMHZwRslzJhcHYgid8/5U6k gILOyq6JfJe2KZCx+2PqkgvEqUlS+QeP1YGLFJtw4cZM55M7UZwsyam6kY2KBx5HYyPz ACOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=R+Ywhrt9LAznzmO9emRhAU0IYZ3ckkoMltrxTLDplTc=; b=HovdWdgSjjMXRzmDEo28plEb5rBSjuWgtYGievowOaTfcMen6rp4kRIX6PUKKH+sLV O13QfIVYjlFgnRjQ1JZvuceYOTTQVxrZh8Ak8tCqkdCugBvmSc81L/5ZzEpzQb6BVqcr 3pdmbdpIe5fN5RbEF+tDiVkD9QZhs89FAAZYt7lRdhzFe9SH/zgib9hhqA23iPO7tl9P 7sDM3duT5QRfTwsATT5jAk0kX9xtiPq/VRkDlIWXzbdCuchtyZNduFabmn2ijEF6CuRL rmQqydzLPdQjK37RFdOjAVOOxTzux/rGBFmFWM8ce51Zx//Zl48xJFSFGLE5+dwRsQ0Z k2Bg== X-Gm-Message-State: ACrzQf3IK9cA2gczJn95AhIOy6l811YJywRANNTJp8kHV+hlZG2OinDR PVnLxEtd1AKtGXG/ipCjCC8= X-Google-Smtp-Source: AMsMyM5wVrsXCJdi+YsrmstSxx8UPbdoe/clDLsH+eFmEOsjzOf1F1OaBjLRh87OfsFnh3UmFdThZQ== X-Received: by 2002:a05:6a00:1898:b0:561:1990:63c0 with SMTP id x24-20020a056a00189800b00561199063c0mr9110443pfh.49.1665215566009; Sat, 08 Oct 2022 00:52:46 -0700 (PDT) Received: from localhost ([1.83.155.53]) by smtp.gmail.com with ESMTPSA id y9-20020a17090322c900b0017f59ebafe7sm1007869plg.212.2022.10.08.00.52.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Oct 2022 00:52:44 -0700 (PDT) From: Ihor Radchenko To: "Christopher M. Miles" Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH 2-v4] New: auto display inline images under subtree when `org-cycle'. In-Reply-To: <633be6d3.370a0220.4060.bacdSMTPIN_ADDED_BROKEN@mx.google.com> References: <631fe1c9.050a0220.3ab2b.3f52SMTPIN_ADDED_BROKEN@mx.google.com> <87bkrhwc42.fsf@localhost> <6322b0a8.050a0220.59bb8.6923SMTPIN_ADDED_BROKEN@mx.google.com> <87y1uluir1.fsf@localhost> <6322f5ad.c80a0220.5e936.823eSMTPIN_ADDED_BROKEN@mx.google.com> <878rmesf64.fsf@localhost> <6329c8b0.050a0220.412d.0a6cSMTPIN_ADDED_BROKEN@mx.google.com> <87tu51xivh.fsf@localhost> <633454e3.050a0220.7278b.1fa5SMTPIN_ADDED_BROKEN@mx.google.com> <87y1u298yn.fsf@localhost> <63353c69.370a0220.67788.e8a1SMTPIN_ADDED_BROKEN@mx.google.com> <87o7ux4khz.fsf@localhost> <6336a955.050a0220.4e72e.2b23SMTPIN_ADDED_BROKEN@mx.google.com> <87bkqw2pzc.fsf@localhost> <63380f57.370a0220.a9d9a.dee8SMTPIN_ADDED_BROKEN@mx.google.com> <878rlxzj5i.fsf@localhost> <633a67d8.050a0220.733e8.e57dSMTPIN_ADDED_BROKEN@mx.google.com> <87sfk4urvz.fsf@localhost> <633be6d3.370a0220.4060.bacdSMTPIN_ADDED_BROKEN@mx.google.com> Date: Sat, 08 Oct 2022 15:53:35 +0800 Message-ID: <87edvikayo.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::536; envelope-from=yantar92@gmail.com; helo=mail-pg1-x536.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1665215608; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=R+Ywhrt9LAznzmO9emRhAU0IYZ3ckkoMltrxTLDplTc=; b=Zvpw5E4nMWx7jDMw52oR/fmxzQmEasSm1VV7eNeokynw6RENLoCUS8H/b8hsJTD209xrmI g3tk5PDZOvDENcvtY7faLiAaSgMT38GigG094RVnEQBvNb9WqDgFooCCAO2UZyTupU/T7L Pjgo5TxhGpOcW/egIoh1FmlIm6li0QnsIcLd2791j+hWQAL3MRBM3uYNcsn8uZHTJ2ltqp RIhsVZ+IAXc6JxHGGNTroZ56uDsmY7gBkAGoy4X1D2S65VMwWDrRHmp29VPECzgyaSLBRc CwNhmWdadWCWZWeo4Tz5RMbSDCwak2dYkQNzElHx23nlSlGj+bu3bx2JaVd1rQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1665215608; a=rsa-sha256; cv=none; b=VBaYpwmF253zKP9TJ7COFqhdUicLtOuTnh2NT2rtxxIdS9HWKe95Q+hSwkExpyuFrLhRG6 92mqDCvyG3Wp6heKxoqKwcr/8dXkGXDEFvzz5cysrEidipsaHRwdORdH3wMvjPqaAUU6w7 X9dddE6v2nMBpnytItSfF0L1vE4uKGNh4Bomma2I3d1WDNq91yTWwt1enG/ZpmzIKwlAgI XN3H1LzomVgznZwH7FYkbTrglaWjPF4JA1uyFnx3HEOkfEdjAADi+JscxKFCyTJsdEBoOV ztnkNGq9iOgsKA7iJNRsVeZQ9WfawprqEBspi8N0oLpkaxdISdcz5ux+/NwbOQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Elo3wvaC; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.38 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Elo3wvaC; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 26B65353EE X-Spam-Score: -3.38 X-Migadu-Scanner: scn1.migadu.com X-TUID: 9/08hgLfD7hk "Christopher M. Miles" writes: >> However, upon testing your patch, tests are still failing on my side. >> Can you please investigate? > > But If I use [M-x ert] to run the test "test-org-fold/org-fold-display-inline-images" is passed. > Here is the steps: > 1. [M-x load-file RET /path/to/org-mode/testing/org-test.el RET] > 2. [C-M-x] to evaluate the target test > 3. [M-x ert RET test-org-fold/org-fold-display-inline-images RET] to run this test > > I attached the uploaded screencast video link to prove it passed. > > https://share.cleanshot.com/tvUUoQ > > I tried many different other API functions to cycle or fold/unfold, but none > of them works under command "make test" or command > "make BTEST_RE="test-org-fold/org-fold-display-inline-images" test-dirty". > > I have nothing brain to think for this test now. Really can't figure out > why this image is not displayed as overlay. Can you help me to fix this test? The problem is with batch mode. `create-image' will return nil in batch mode and hence no overlays are ever created even though `org-display-inline-images' does get called. I think that the best we can do in this situation is mocking `create-image' in batch mode to return non-nil using `cl-letf'. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at