From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 4J+yNlc+LWR4zQAASxT56A (envelope-from ) for ; Wed, 05 Apr 2023 11:24:40 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id GDSDNVc+LWSY7wAAG6o9tA (envelope-from ) for ; Wed, 05 Apr 2023 11:24:39 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6E7DBEC47 for ; Wed, 5 Apr 2023 11:24:39 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pjzMx-0001VH-Qo; Wed, 05 Apr 2023 05:23:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pjzMt-0001V6-Ra for emacs-orgmode@gnu.org; Wed, 05 Apr 2023 05:23:52 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pjzMp-0003iZ-Pf for emacs-orgmode@gnu.org; Wed, 05 Apr 2023 05:23:51 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 27830240121 for ; Wed, 5 Apr 2023 11:23:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1680686624; bh=ShPDp46iG2CuZZ0EleI4gFokFO+YuNsQ4h8UsDTHjB4=; h=From:To:Cc:Subject:Date:From; b=YZk0rYPCix7o9wbPh5V49uHr73qVNDojy1/u8z+6ZISXFUNt7eGNnukFkRUQiXOiZ 4SWnWwkhGHelph2rZZxEDUhU0dTmzX/XiJToDS3SaQTYOnrOhDSmXOeOSMBYhAqPKB t/KOYA8dMNZfcVJs+gK7f6775N+Ncf1GizjfnR3IziVEesCyHG/55cN10r3VyI43PI syPcxJdr2mz+tB2qHTb91R5tjlU80jTqmRCiCdDIE7s3BfUk423b8jpB8F1nhPMN30 8P1Esmm1VeQYwdsz1t1qVSI2x9Amg4xX+sGSckqSpHLUIAeo0G3UNBU5mCAacM6Um2 8NYkHqz2PgaFw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Przhb4NS9z6tvs; Wed, 5 Apr 2023 11:23:43 +0200 (CEST) From: Ihor Radchenko To: Feraidoon Mehri Cc: Bastien , emacs-orgmode@gnu.org Subject: Re: [PATCH] ox.el: Refactor variable org-html--id-attr-prefix, ox-html.el: Add support for the ID property to org-html--reference In-Reply-To: <87a646l45u.fsf@localhost> References: <87ilk8tlqd.fsf@localhost> <87a646l45u.fsf@localhost> Date: Wed, 05 Apr 2023 09:26:02 +0000 Message-ID: <87edoyk7dh.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1680686679; a=rsa-sha256; cv=none; b=PhSGt0MJ8ZC+W7n/AfqRqdWi9MJuS47ygiYzo5xkw8MBWbmCx9Gf1n4NaBPYgSlUJK/Kxw rdhXYYCKRtdKhblPZ6GPizmjy/cuklcnO6BQWxJ/N0cQxsn7b24ZT+aA7QOhLrNHn8YdpZ ty1kpcKINbQ6g/+k9k1Y4FRaOnSyEnxSULHRzTehm1LW4swdG73C0tZgbNBvv50kU80vwO WW4E6hmafhH8qqngUGEaqoEiw0sz9+UXi4LYXLG146TjjvVVd5B0QLO1aoaVlklbgy3VxE +0vIThdI+80Y8Gv1n3oW0LvG+biYfA6PH9kI4fqopaK3Ks45sTLxmV3roFmr6A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=YZk0rYPC; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1680686679; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=JW70+55uD/+OxR3mPo6b8AO0lfsYDOvAZin+ES68v/Y=; b=RrdkOripT3P3Zx08+L3HrF78lvf1k7DI7aEQy2s2/xFck6ZdHciV+vD/TP+CtO5ysvUlu2 hdj3+18l3+cO/vjEUKIBE0G8rnWmkiiI9G9ZmXv8uP9pZkPRo3RG5o9OzJEN5ZmTAcvudQ jOlDjRUHL1vsoe0prPgoQnrbY8NFYhM4izuO1PcFCB2VacmEfDstcgvhEEMyA586F2VzZz MPbIeo2bJd1zEelGu/51i+63tnpsfICROwhSNo/qdEPQufEGNdb8XFwGiQvwOrzVduzASa stJHb8ZGJr9hQhrQKinQ1h7B1eU47lzzmItDrzDYAXd6XDdbK7zFP2dQiNF/KQ== X-Migadu-Spam-Score: -6.21 X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=YZk0rYPC; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Spam-Score: -6.21 X-Migadu-Queue-Id: 6E7DBEC47 X-TUID: RJsnDydJ23xJ Ihor Radchenko writes: > Ihor Radchenko writes: > >> Thanks for the patch! >> See my comments below. > > Feraidoon, have you had a chance to look into my comments? Applied, with amendments, onto main. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=5e9953fa0 You are now listed as an Org contributor. https://git.sr.ht/~bzg/worg/commit/fb807476 -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at