From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id iNckOr1FvGRyFwEASxT56A (envelope-from ) for ; Sat, 22 Jul 2023 23:10:22 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id IKchOr1FvGQ79wAA9RJhRA (envelope-from ) for ; Sat, 22 Jul 2023 23:10:21 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 72297470DB for ; Sat, 22 Jul 2023 23:10:21 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=ericabrahamsen.net (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1690060221; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=YU+f/KA+q+QHFLuMnhP3+qrGYwevwrqBXAG4ZDT9jeg=; b=qMX3F6bBnkK0ibadaCq22lPAAsVJhA2BRSeu6vo4NGMeU1i4D/rYccxqb4MIvd1rHmEsRG 5UiXO182dcELaEDqtuEQaNa7GSgadixDYJVqlLU7vltTEyWT1yMEWgJ6EuM7zSByQBJz+w WSqL+QsDAYtdtC+N12KBbo/kPRsPYeFM+ktAQ2jOk8aKERL3TRYoEYe2SBNPX9PfIQoFUf Jd2Iz8V3eJmMlA03fNjpgf5RJKZgOT8+Dj7zYZKfVndf4nnTRsDmAtrM83+xqDeaRCgcry HC/7fHpW2fAsCVL2l4llLwqe5ioWfavfZL0ajAYPmv5pnJ+idSfjI4eWLu51Fg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1690060221; a=rsa-sha256; cv=none; b=gUq8PcgwGB+Dgz0/N7SMsxxSHIl1iMIRyMH26Ef6/JZr+UNN6jQKCSa4V7gVYppLN0bg8r 9sBBe9te3iLKFtpvYg3bV3ZmVXxkIMCsm18nH+VoUOdCs4tpSO4NSvR47adlxL2kCdkWGo HN2n7hLJgf7RuW6jt5g2aS2S1waJs5TRddeg0Fw++SxFVMHhKwaZSw9+QTBOEavsLcqcxB Kp4vtnDnKubRy+yml5ooOa/tUjlTYKWC54HWS+/FIq5uxTBYnBgag9g5ufpHSyAP0CgsZY pz183+j1N75k3rAjChOlHwS/gUW3pFunig0VYf+mUjMsPS4MDryHOForCKiSKQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=ericabrahamsen.net (policy=none) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qNJqs-0004Yl-8P; Sat, 22 Jul 2023 17:09:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qNJqq-0004YW-QS for emacs-orgmode@gnu.org; Sat, 22 Jul 2023 17:09:20 -0400 Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qNJqo-0005R3-NW for emacs-orgmode@gnu.org; Sat, 22 Jul 2023 17:09:20 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1qNJqm-0004yL-J2 for emacs-orgmode@gnu.org; Sat, 22 Jul 2023 23:09:16 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Eric Abrahamsen Subject: Re: [BUG] Issues in ol-gnus when storing links in nnvirtual and nnselect articles [9.7-pre (release_9.6.7-570-gd6f3ae.dirty @ /home/jschmidt/work/org-mode/lisp/)] Date: Sat, 22 Jul 2023 14:09:07 -0700 Message-ID: <87edkzveks.fsf@ericabrahamsen.net> References: <2fa5914d-2cbf-f41f-8be6-e79e77794140@vodafonemail.de> <87y1j8rrag.fsf@localhost> <1b9fbe38-0572-7861-e433-8f26457302bb@vodafonemail.de> Mime-Version: 1.0 Content-Type: text/plain User-Agent: Gnus/5.13 (Gnus v5.13) Cancel-Lock: sha1:kKZYLOhFKU0vY4MPdmOiYAUABMI= Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.69 X-Spam-Score: -2.69 X-Migadu-Queue-Id: 72297470DB X-Migadu-Scanner: mx1.migadu.com X-TUID: mpNvXrCU+Dh0 Jens Schmidt writes: > On 2023-07-22 15:48, Ihor Radchenko wrote: > >> I am not familiar with Gnus, but looking at the code, may it be that >> a Gnus article is open when Gnus summary buffer is not? > > Theoretically yes, if you actively and malignantly kill the summary > buffer, for example. In practice and through Gnus key bindings, this > should not happen. IOW, Gnus stops behaving reasonably as well if you > kill the summary buffer other than through Gnus key bindings > ("Selecting deleted buffer", etc.). > > If you check function `gnus-summary-work-articles' from gnus-sum.el, the > main work horse for article processing and also good for calling in > article buffers, you will note (focusing on the default case) the same > paradigm > > (with-current-buffer gnus-summary-buffer > (cond > [...] > (t > ;; Just return the current article. > (list (gnus-summary-article-number)))))) > > As a last resort we could also try to drag in Andrew Cohen as a > reviewer, he has been helpful already with one or two of my Gnus bugs. We should definitely be using the paradigm above (using the gnus-summary-buffer as the current buffer). The article number fetching only works by accident in the article buffer, and other stuff (like finding the original nnselect group name) won't work at all. Later in the function we've got this: (save-window-excursion (save-excursion (gnus-article-show-summary) (gnus-summary-article-header))) If we're currently in article-mode. The call to `gnus-article-show-summary' would protect against the case where the summary buffer has been killed in the meantime, but I agree that's kind of a pathological case. Probably it would be enough to wrap the whole containing `let*' in a (with-current-buffer gnus-summary-buffer ...). If we're already in the summary buffer, no harm done. Eric